From 27d31d61c072bf03a052a0e6a9da0724561185da Mon Sep 17 00:00:00 2001 From: Justin Edmund Date: Sat, 3 Dec 2022 13:55:41 -0800 Subject: [PATCH] Fix race condition --- app/controllers/api/v1/jobs_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/api/v1/jobs_controller.rb b/app/controllers/api/v1/jobs_controller.rb index 3191380..5866d32 100644 --- a/app/controllers/api/v1/jobs_controller.rb +++ b/app/controllers/api/v1/jobs_controller.rb @@ -11,7 +11,6 @@ class Api::V1::JobsController < Api::V1::ApiController # Extract job and find its main skills job = Job.find(job_params[:job_id]) - main_skills = JobSkill.where(job: job.id, main: true) # Update the party @@ -22,7 +21,8 @@ class Api::V1::JobsController < Api::V1::ApiController # Check for incompatible Base and EMP skills %w[skill1_id skill2_id skill3_id].each do |key| - @party[key] = nil if mismatched_skill(@party.job, JobSkill.find(@party[key])) + ap "In here with #{key}" + @party[key] = nil if @party[key] && mismatched_skill(@party.job, JobSkill.find(@party[key])) end render :update, status: :ok if @party.save!