granblue.team/hensei-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix rescue_from order so StandardError is checked last

Browse source
This commit is contained in:
Justin Edmund 2025-12-14 01:48:11 -08:00
parent d4131cf51d
commit 349b542c0e
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/controllers/api/v1/api_controller.rb
View file

@ -13,6 +13,14 @@ module Api
MIN_PER_PAGE = 1
##### Errors
# Catch-all for unhandled exceptions - log details and return 500
# NOTE: Must be defined FIRST so it's checked LAST (Rails matches bottom-to-top)
rescue_from StandardError do |e|
Rails.logger.error "[500 Error] #{e.class}: #{e.message}"
Rails.logger.error e.backtrace&.first(20)&.join("\n")
render json: { error: 'Internal Server Error', message: e.message }, status: :internal_server_error
end
rescue_from ActiveRecord::RecordInvalid, with: :render_unprocessable_entity_response
rescue_from ActiveRecord::RecordNotDestroyed, with: :render_unprocessable_entity_response
rescue_from ActiveRecord::RecordNotFound, with: :render_not_found_response_without_object
@ -44,13 +52,6 @@ module Api
render_error(e)
end
# Catch-all for unhandled exceptions - log details and return 500
rescue_from StandardError do |e|
Rails.logger.error "[500 Error] #{e.class}: #{e.message}"
Rails.logger.error e.backtrace&.first(20)&.join("\n")
render json: { error: 'Internal Server Error', message: e.message }, status: :internal_server_error
end
##### Hooks
before_action :current_user
before_action :default_content_type