Move to JobSkillsController

It makes more sense to pre-fetch all job skills and filter on the client, so we're consolidating into a JobSkillsController
This commit is contained in:
Justin Edmund 2022-11-27 19:27:45 -08:00
parent 5755aab240
commit 353db31ef7
5 changed files with 21 additions and 10 deletions

View file

@ -0,0 +1,13 @@
class Api::V1::JobSkillsController < Api::V1::ApiController
def all
@skills = JobSkill.all()
render :all, status: :ok
end
def job
job = Job.find(params[:id])
@skills = JobSkill.where(job: job).or(JobSkill.where(sub: true))
render :all, status: :ok
end
end

View file

@ -3,11 +3,4 @@ class Api::V1::JobsController < Api::V1::ApiController
@jobs = Job.all()
render :all, status: :ok
end
def skills
job = Job.find(params[:id])
@skills = JobSkill.where(job: job).or(JobSkill.where(sub: true))
render :skills, status: :ok
end
end

View file

@ -0,0 +1,3 @@
collection @skills, object_root: false
extends 'job_skills/base'

View file

@ -1,4 +1,4 @@
collection @skills, object_root: false
object :job_skill
attributes :id, :job, :slug, :color, :main, :base, :sub, :emp, :order
@ -8,4 +8,3 @@ node :name do |w|
:ja => w.name_jp
}
end

View file

@ -27,7 +27,10 @@ Rails.application.routes.draw do
post 'search/summons', to: 'search#summons'
get 'jobs', to: 'jobs#all'
get 'jobs/:id/skills', to: 'jobs#skills'
get 'jobs/skills', to: 'job_skills#all'
get 'jobs/:id/skills', to: 'job_skills#job'
get 'raids', to: 'raids#all'
get 'weapon_keys', to: 'weapon_keys#all'