Add new errors and fix handling in ApiController

app/controllers/api/v1/api_controller.rb

@@ -16,6 +16,10 @@ module Api::V1
     rescue_from Api::V1::UnauthorizedError, with: :render_unauthorized_response
     rescue_from ActionController::ParameterMissing, with: :render_unprocessable_entity_response
 
+    rescue_from StandardError do |e|
+      render_error(e)
+    end
+
     ##### Hooks
     before_action :current_user
     before_action :set_default_content_type
@@ -45,13 +49,17 @@ module Api::V1
     end
 
     ### Error response methods
+    def render_error(error)
+      render action: 'errors', json: error.to_hash, status: error.http_status
+    end
+
     def render_unprocessable_entity_response(exception)
       @exception = exception
       render action: 'errors', status: :unprocessable_entity
     end
 
     def render_not_found_response
-            response = { errors: [{ message: "Record could not be found.", code: "not_found" }]}
+      response = { errors: [{ message: "Record could not be found.", code: "not_found" }] }
       render 'not_found', status: :not_found
     end
 

app/errors/api/v1/IncompatibleSkillError.rb

@@ -0,0 +1,29 @@
+module Api::V1
+  class IncompatibleSkillError < StandardError
+    def initialize(data)
+      @data = data
+    end
+    
+    def http_status
+      422
+    end
+
+    def code
+      'incompatible_skill'
+    end
+
+    def message
+      'The selected skill cannot be added to the current job'
+    end
+
+    def to_hash
+      ap @data
+      {
+        message: message,
+        code: code,
+        job: @data[:job],
+        skill: @data[:skill]
+      }
+    end
+  end
+end

app/errors/api/v1/NoJobProvidedError.rb

@@ -9,7 +9,7 @@ module Api::V1
     end
 
     def message
-            "A job ID must be provided to search for job skills"
+      "A job ID must be provided"
     end
 
     def to_hash

app/errors/api/v1/NoJobSkillProvidedError.rb

@@ -0,0 +1,22 @@
+module Api::V1
+  class NoJobSkillProvidedError < StandardError
+    def http_status
+      422
+    end
+
+    def code
+      "no_job_skill_provided"
+    end
+
+    def message
+      "A job skill ID must be provided"
+    end
+
+    def to_hash
+      {
+        message: message,
+        code: code
+      }
+    end
+  end
+end

app/errors/api/v1/TooManySkillsOfTypeError.rb

@@ -23,7 +23,7 @@ module Api
         {
           message: message,
           code: code,
-          idea_id: @data[:skill_type]
+          skill_type: @data[:skill_type]
         }
       end
     end