From 579736e981dbb4d6045010666df51c46aa44529b Mon Sep 17 00:00:00 2001 From: Justin Edmund Date: Mon, 15 Dec 2025 16:53:44 -0800 Subject: [PATCH] remove gacha_available from character parsers/importers --- lib/granblue/importers/character_importer.rb | 4 +--- lib/granblue/parsers/character_parser.rb | 2 -- lib/granblue/parsers/suggestion_parser.rb | 3 --- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/granblue/importers/character_importer.rb b/lib/granblue/importers/character_importer.rb index 09f7ba7..1f46a17 100644 --- a/lib/granblue/importers/character_importer.rb +++ b/lib/granblue/importers/character_importer.rb @@ -61,7 +61,6 @@ module Granblue # @option attributes [Array] :nicknames_jp Japanese nicknames # @option attributes [Integer] :season Character season (gacha availability window) # @option attributes [Array] :series Character series (identity/pool membership) - # @option attributes [Boolean] :gacha_available Whether character can be pulled from gacha # # @raise [ImportError] If required attributes are missing or invalid def build_attributes(row) @@ -102,8 +101,7 @@ module Granblue nicknames_en: parse_array(row['nicknames_en']), nicknames_jp: parse_array(row['nicknames_jp']), season: parse_integer(row['season']), - series: parse_integer_array(row['series']), - gacha_available: parse_boolean(row['gacha_available']) + series: parse_integer_array(row['series']) } end end diff --git a/lib/granblue/parsers/character_parser.rb b/lib/granblue/parsers/character_parser.rb index a86448c..20326c5 100644 --- a/lib/granblue/parsers/character_parser.rb +++ b/lib/granblue/parsers/character_parser.rb @@ -196,7 +196,6 @@ module Granblue info[:series] = series_from_hash(hash) info[:season] = season_from_hash(hash) - info[:gacha_available] = gacha_available_from_hash(hash) info.compact end @@ -213,7 +212,6 @@ module Granblue @character.series = hash[:series] if hash[:series].present? @character.season = hash[:season] if hash[:season].present? - @character.gacha_available = hash[:gacha_available] unless hash[:gacha_available].nil? if @character.save ap "#{@character.granblue_id}: Successfully saved info for #{@character.name_en}" if @debug diff --git a/lib/granblue/parsers/suggestion_parser.rb b/lib/granblue/parsers/suggestion_parser.rb index 7161b78..09798a5 100644 --- a/lib/granblue/parsers/suggestion_parser.rb +++ b/lib/granblue/parsers/suggestion_parser.rb @@ -88,9 +88,6 @@ module Granblue # Season (from series field) suggestions[:season] = character_season_from_series(wiki_series, obtain) - # Gacha available (from obtain field) - suggestions[:gacha_available] = gacha_available_from_obtain(obtain, wiki_series) - # Promotions (from obtain and series fields) promotions = character_promotions_from_obtain(obtain, wiki_series) suggestions[:promotions] = promotions if promotions.any?