From 588d682801796979d756298aaa1f96afadb7d8af Mon Sep 17 00:00:00 2001 From: Justin Edmund Date: Sun, 9 Feb 2025 18:12:38 -0800 Subject: [PATCH] Eager-load jobs when querying job skills --- app/controllers/api/v1/job_skills_controller.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/controllers/api/v1/job_skills_controller.rb b/app/controllers/api/v1/job_skills_controller.rb index 8b466a1..f98ddf8 100644 --- a/app/controllers/api/v1/job_skills_controller.rb +++ b/app/controllers/api/v1/job_skills_controller.rb @@ -4,11 +4,13 @@ module Api module V1 class JobSkillsController < Api::V1::ApiController def all - render json: JobSkillBlueprint.render(JobSkill.all) + render json: JobSkillBlueprint.render(JobSkill.includes(:job).all) end def job - @skills = JobSkill.where('job_id != ? AND emp = ?', params[:id], true) + @skills = JobSkill.includes(:job) + .where.not(job_id: params[:id]) + .where(emp: true) render json: JobSkillBlueprint.render(@skills) end end