granblue.team/hensei-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix build_conditions method

Browse source 
The method of assigning values was assigning nil if the value wasn't present in `params`, which is bad
This commit is contained in:
Justin Edmund 2022-12-21 16:20:00 -08:00
parent 5b37e480f8
commit af51869927
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/controllers/api/v1/parties_controller.rb
View file

@ -55,6 +55,7 @@ module Api
def index
conditions = build_conditions(request.params)
ap conditions
@parties = Party.where(conditions)
.order(created_at: :desc)
@ -105,12 +106,12 @@ module Api
.to_datetime.beginning_of_day
end
{
element: (params['element'] unless params['element'].blank?),
raid: (params['raid'] unless params['raid'].blank?),
created_at: (start_time..now unless params['recency'].blank?),
weapons_count: 5..13
}
{}.tap do |hash|
hash[:element] = params['element'] unless params['element'].blank?
hash[:raid] = params['raid'] unless params['raid'].blank?
hash[:created_at] = start_time..now unless params['recency'].blank?
hash[:weapons_count] = 5..13
end
end
def random_string