Update PR templates again (#164)

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,9 +1,5 @@
-blank_issues_enabled: false
+Choose a PR template:
-contact_links:
 
-- name: Default Pull Request
+* [General]("?expand=1&template=.github/PULL_REQUEST_TEMPLATE/default.md"): For general changes like feature additions
-  url: .github/PULL_REQUEST_TEMPLATE/default.md
+  and issue resolution
-  about: For general changes and updates
+* [Data Update]("?expand=1&template=.github/PULL_REQUEST_TEMPLATE/data_update.md"): For game data updates
-- name: Data Update Pull Request
-  url: .github/PULL_REQUEST_TEMPLATE/data_update.md
-  about: For game data updates and modifications

.github/PULL_REQUEST_TEMPLATE/data_update.md

@@ -1,68 +1,46 @@
-name: Data Update
+# Data Update
-description: For game data updates and modifications
+
-body:
+## Summary
+
+<!-- Describe what this data update includes -->
+<!-- Example: Adding new Valentines 2024 characters -->
+
+## New Additions
+
+<!-- Copy the list of newly added items from the Import Summary -->
 
-- type: markdown
-  attributes:
-  value: |
-  ## Data Update
-- type: textarea
-  id: summary
-  attributes:
-  label: Summary
-  description: Describe what this data update includes
-  placeholder: "Adding new Valentines 2024 characters"
-  validations:
-  required: true
-- type: textarea
-  id: new-additions
-  attributes:
-  label: New Additions
-  description: List new items being added, grouped by type
-  value: |
 ##### Characters
 - 
+
 ##### Weapons
 - 
+
 ##### Summons
 - 
-- type: textarea
+
-  id: modifications
+## Modifications
-  attributes:
+
-  label: Modifications
+<!-- Copy the list of modified items from the Import Summary -->
-  description: List existing items being modified
+
-  value: |
 ##### Characters
 - 
+
 ##### Weapons
 - 
+
 ##### Summons
 -
-- type: textarea
+
-  id: csv-files
+## Checklist
-  attributes:
+
-  label: CSV Files Added
+- [ ] CSV files use the correct naming format (`YYYYMMDD-{type}-XXX.csv`)
-  description: List all CSV files included in this update
+- [ ] CSV files are in the correct location (`db/seed/updates/`)
-  value: |
+- [ ] All required fields are filled out
-    - [ ] `YYYYMMDD-characters-XXX.csv`
+- [ ] Dates use the correct format (`YYYY-MM-DD`)
-    - [ ] `YYYYMMDD-weapons-XXX.csv`
+- [ ] Boolean values are either `true` or `false`
-    - [ ] `YYYYMMDD-summons-XXX.csv`
+- [ ] Arrays use the correct format (e.g., `{value1,value2}`)
-- type: checkboxes
+- [ ] Ran import in test mode (`bin/rails granblue:import_data TEST=true`)
-  id: data-checklist
+
-  attributes:
+## Test Results
-  label: Checklist
+
-  options:
+<!-- Paste the completion section from running the import in test mode -->
-    - label: CSV files use the correct naming format (`YYYYMMDD-{type}-XXX.csv`)
-    - label: CSV files are in the correct location (`db/seed/updates/`)
-    - label: All required fields are filled out
-    - label: Dates use the correct format (`YYYY-MM-DD`)
-    - label: Boolean values are either `true` or `false`
-    - label: Arrays use the correct format (e.g., `{value1,value2}`)
-    - label: Ran import in test mode (`bin/rails granblue:import_data TEST=true`)
-- type: textarea
-  id: test-results
-  attributes:
-  label: Test Results
-  description: Paste the output from running the import in test mode
-  validations:
-  required: true

.github/PULL_REQUEST_TEMPLATE/default.md

@@ -1,26 +1,21 @@
-name: Default Pull Request
+# Pull Request
-description: For general changes and updates
-body:
 
-- type: markdown
-  attributes:
-  value: |
 ## Description
+
 Please provide a clear description of your changes.
-- type: textarea
+
-  id: changes
+## Changes Made
-  attributes:
+
-  label: Changes Made
+<!-- List the main changes in this PR -->
-  description: List the main changes in this PR
+<!-- Example:
-  placeholder: "- Added feature X\n- Fixed bug Y\n- Updated documentation for Z"
+- Added feature X
-  validations:
+- Fixed bug Y
-  required: true
+- Updated documentation for Z
-- type: checkboxes
+-->
-  id: checks
+
-  attributes:
+## Checklist
-  label: Checklist
+
-  options:
+- [ ] I have tested my changes
-    - label: I have tested my changes
+- [ ] I have updated relevant documentation
-    - label: I have updated relevant documentation
+- [ ] My changes generate no new warnings
-    - label: My changes generate no new warnings
+- [ ] I have added tests if applicable
-    - label: I have added tests if applicable