granblue.team/hensei-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix deleting grid summons (#112)

Browse source 
A bad decision to try to reduce code in `set` made this fail with a 422 because `summon_params` was being tested against but... didn't exist? was nil?

I fixed it by not using `set` before calling `destroy`, and just finding the summon in the `destroy` method itself
This commit is contained in:
Justin Edmund 2023-07-01 21:53:48 -07:00 committed by GitHub
parent 5c8955d0cc
commit f81f43e501
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/controllers/api/v1/grid_summons_controller.rb
View file

@ -5,7 +5,7 @@ module Api
class GridSummonsController < Api::V1::ApiController class GridSummonsController < Api::V1::ApiController
attr_reader :party, :incoming_summon attr_reader :party, :incoming_summon
before_action :set, only: %w[update update_uncap_level update_quick_summon destroy] before_action :set, only: %w[update update_uncap_level update_quick_summon]
before_action :find_party, only: :create before_action :find_party, only: :create
before_action :find_incoming_summon, only: :create before_action :find_incoming_summon, only: :create
before_action :authorize, only: %i[create update update_uncap_level update_quick_summon destroy] before_action :authorize, only: %i[create update update_uncap_level update_quick_summon destroy]
@ -111,8 +111,9 @@ module Api
end end
def destroy def destroy
render_unauthorized_response if @summon.party.user != current_user summon = GridSummon.find_by('id = ?', params[:id])
return render json: GridSummonBlueprint.render(@summon, view: :destroyed) if @summon.destroy render_unauthorized_response if summon.party.user != current_user
return render json: GridSummonBlueprint.render(summon, view: :destroyed) if summon.destroy
end end
private private
@ -142,8 +143,7 @@ module Api
end end
def set def set
id = summon_params[:id] ? summon_params[:id] : params[:id] @summon = GridSummon.find_by('id = ?', summon_params[:id])
@summon = GridSummon.where('id = ?', id).first
end end
# Specify whitelisted properties that can be modified. # Specify whitelisted properties that can be modified.