Some final post-deploy fixes (#161)

* Fix track_record error

* Add newlines

* Update PR templates
This commit is contained in:
Justin Edmund 2025-01-15 18:06:20 -08:00 committed by GitHub
parent 52f213d4cb
commit fa386511e1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 112 additions and 45 deletions

9
.github/PULL_REQUEST_TEMPLATE.md vendored Normal file
View file

@ -0,0 +1,9 @@
blank_issues_enabled: false
contact_links:
- name: Default Pull Request
url: .github/PULL_REQUEST_TEMPLATE/default.md
about: For general changes and updates
- name: Data Update Pull Request
url: .github/PULL_REQUEST_TEMPLATE/data_update.md
about: For game data updates and modifications

View file

@ -0,0 +1,68 @@
name: Data Update
description: For game data updates and modifications
body:
- type: markdown
attributes:
value: |
## Data Update
- type: textarea
id: summary
attributes:
label: Summary
description: Describe what this data update includes
placeholder: "Adding new Valentines 2024 characters"
validations:
required: true
- type: textarea
id: new-additions
attributes:
label: New Additions
description: List new items being added, grouped by type
value: |
##### Characters
-
##### Weapons
-
##### Summons
-
- type: textarea
id: modifications
attributes:
label: Modifications
description: List existing items being modified
value: |
##### Characters
-
##### Weapons
-
##### Summons
-
- type: textarea
id: csv-files
attributes:
label: CSV Files Added
description: List all CSV files included in this update
value: |
- [ ] `YYYYMMDD-characters-XXX.csv`
- [ ] `YYYYMMDD-weapons-XXX.csv`
- [ ] `YYYYMMDD-summons-XXX.csv`
- type: checkboxes
id: data-checklist
attributes:
label: Checklist
options:
- label: CSV files use the correct naming format (`YYYYMMDD-{type}-XXX.csv`)
- label: CSV files are in the correct location (`db/seed/updates/`)
- label: All required fields are filled out
- label: Dates use the correct format (`YYYY-MM-DD`)
- label: Boolean values are either `true` or `false`
- label: Arrays use the correct format (e.g., `{value1,value2}`)
- label: Ran import in test mode (`bin/rails granblue:import_data TEST=true`)
- type: textarea
id: test-results
attributes:
label: Test Results
description: Paste the output from running the import in test mode
validations:
required: true

View file

@ -0,0 +1,26 @@
name: Default Pull Request
description: For general changes and updates
body:
- type: markdown
attributes:
value: |
## Description
Please provide a clear description of your changes.
- type: textarea
id: changes
attributes:
label: Changes Made
description: List the main changes in this PR
placeholder: "- Added feature X\n- Fixed bug Y\n- Updated documentation for Z"
validations:
required: true
- type: checkboxes
id: checks
attributes:
label: Checklist
options:
- label: I have tested my changes
- label: I have updated relevant documentation
- label: My changes generate no new warnings
- label: I have added tests if applicable

View file

@ -1,41 +0,0 @@
## Data Update
### Summary
<!-- Describe what this data update includes. For example: "Adding new Valentines 2024 characters" -->
#### New Additions
<!-- List new items being added, grouped by type -->
- Characters:
- [ ]
- Weapons:
- [ ]
- Summons:
- [ ]
#### Modifications
<!-- List existing items being modified -->
- Characters:
- [ ]
- Weapons:
- [ ]
- Summons:
- [ ]
### CSV Files Added
<!-- List all CSV files included in this update -->
- [ ] `YYYYMMDD-characters-XXX.csv`
- [ ] `YYYYMMDD-weapons-XXX.csv`
- [ ] `YYYYMMDD-summons-XXX.csv`
### Checklist
<!-- Make sure all these items are completed -->
- [ ] CSV files use the correct naming format (`YYYYMMDD-{type}-XXX.csv`)
- [ ] CSV files are in the correct location (`db/seed/updates/`)
- [ ] All required fields are filled out
- [ ] Dates use the correct format (`YYYY-MM-DD`)
- [ ] Boolean values are either `true` or `false`
- [ ] Arrays use the correct format (e.g., `{value1,value2}`)
- [ ] Ran import in test mode (`bin/rails granblue:import_data TEST=true`)
### Test Results
<!-- Paste the output from running the import in test mode -->

View file

@ -209,11 +209,16 @@ module Granblue
record, was_updated = result
type = model_class.name.demodulize.downcase
record_info = {
granblue_id: record.granblue_id,
name_en: record.name_en
}
if was_updated
@updated_records[type] << record.granblue_id
@updated_records[type] << record_info
log_updated_record(record) if @verbose
else
@new_records[type] << record.granblue_id
@new_records[type] << record_info
log_new_record(record) if @verbose
end
end
@ -247,11 +252,11 @@ module Granblue
end
def log_new_record(record)
@logger&.log_verbose("Created #{model_class.name} with ID: #{record.granblue_id}")
@logger&.log_verbose("Created #{model_class.name} with ID: #{record.granblue_id}\n")
end
def log_updated_record(record)
@logger&.log_verbose("Updated #{model_class.name} with ID: #{record.granblue_id}")
@logger&.log_verbose("Updated #{model_class.name} with ID: #{record.granblue_id}\n")
end
def parse_value(value)