From 073bed01d37a8102246c50daf222d0c496c38da2 Mon Sep 17 00:00:00 2001
From: Justin Edmund <justin@jedmund.com>
Date: Fri, 28 Nov 2025 21:04:39 -0800
Subject: [PATCH] fix: component props and type assertions

- make UncapIndicator StarRender props optional for transcendence stars
- add type assertion for star props spreading (as any)
- fix element name type (string -> literal union with type assertion)
- fix PartySegmentedControl props (value/onValueChange -> selectedTab/onTabChange)
- remove userGender prop (component gets it from context)
- add type assertions for ResourceType and ImageVariant comparisons
- add required id/shortcode to Party object in teams/new
- fix auth hooks expiresAt (undefined -> empty string default)
- add type assertion for Select value binding (excludes null/boolean)
---
 src/hooks.server.ts                            |  2 +-
 src/lib/components/ui/DetailItem.svelte        |  2 +-
 src/lib/components/ui/DetailsHeader.svelte     |  4 ++--
 src/lib/components/uncap/UncapIndicator.svelte | 12 ++++++++----
 src/routes/teams/new/+page.svelte              |  7 ++++---
 src/routes/test/images/+page.svelte            |  4 ++--
 6 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/hooks.server.ts b/src/hooks.server.ts
index 98e3a8fe..51f4627d 100644
--- a/src/hooks.server.ts
+++ b/src/hooks.server.ts
@@ -28,7 +28,7 @@ export const handleSession: Handle = async ({ event, resolve }) => {
 		? {
 				accessToken: account.token,
 				user: user,
-				expiresAt: account.expires_at
+				expiresAt: account.expires_at ?? ''
 		  }
 		: null
 
diff --git a/src/lib/components/ui/DetailItem.svelte b/src/lib/components/ui/DetailItem.svelte
index 91040001..24c27a70 100644
--- a/src/lib/components/ui/DetailItem.svelte
+++ b/src/lib/components/ui/DetailItem.svelte
@@ -44,7 +44,7 @@
 	{#if editable}
 		<div class="edit-value">
 			{#if type === 'select' && options}
-				<Select bind:value {options} {placeholder} size="medium" contained />
+				<Select bind:value={value as string | number | undefined} {options} {placeholder} size="medium" contained />
 			{:else if type === 'checkbox'}
 				<label class="checkbox-wrapper">
 					<input type="checkbox" bind:checked={checkboxValue} class="checkbox" />
diff --git a/src/lib/components/ui/DetailsHeader.svelte b/src/lib/components/ui/DetailsHeader.svelte
index c5470f23..9bb9b200 100644
--- a/src/lib/components/ui/DetailsHeader.svelte
+++ b/src/lib/components/ui/DetailsHeader.svelte
@@ -40,7 +40,7 @@
 
 	// Get element name for button styling
 	const elementName = $derived((() => {
-		const elementMap: Record<number, string> = {
+		const elementMap: Record<number, string | undefined> = {
 			0: undefined, // Null element
 			1: 'wind',
 			2: 'fire',
@@ -109,7 +109,7 @@
 				<Button
 					variant="primary"
 					size="medium"
-					element={elementName}
+					element={elementName as "fire" | "water" | "earth" | "wind" | "light" | "dark" | undefined}
 					onclick={onSave}
 					disabled={isSaving}
 				>
diff --git a/src/lib/components/uncap/UncapIndicator.svelte b/src/lib/components/uncap/UncapIndicator.svelte
index 5e9ccca8..feaa77fb 100644
--- a/src/lib/components/uncap/UncapIndicator.svelte
+++ b/src/lib/components/uncap/UncapIndicator.svelte
@@ -21,7 +21,11 @@
 
 	interface StarRender {
 		type: 'uncap' | 'transcendence'
-		props: Record<string, any>
+		props: {
+			index?: number
+			onStarClick?: (index: number, empty: boolean) => void
+			[key: string]: any
+		}
 	}
 
 	let {
@@ -97,7 +101,7 @@
 				ulb: options.ulb,
 				special: options.special,
 				tabIndex: editable ? 0 : undefined,
-				onStarClick: editable ? toggleStar : undefined
+				onStarClick: editable ? toggleStar : () => {}
 			}
 		}
 	}
@@ -160,9 +164,9 @@
 			{@const star = renderStar(i)}
 			{#if star}
 				{#if star.type === 'transcendence'}
-					<TranscendenceStar {...star.props} />
+					<TranscendenceStar {...(star.props as any)} />
 				{:else}
-					<UncapStar {...star.props} />
+					<UncapStar {...(star.props as any)} />
 				{/if}
 			{/if}
 		{/each}
diff --git a/src/routes/teams/new/+page.svelte b/src/routes/teams/new/+page.svelte
index b0a78a8e..bb49d62b 100644
--- a/src/routes/teams/new/+page.svelte
+++ b/src/routes/teams/new/+page.svelte
@@ -550,16 +550,17 @@
       </header>
 
       <PartySegmentedControl
-        value={activeTab}
-        onValueChange={selectTab}
+        selectedTab={activeTab}
+        onTabChange={selectTab}
         party={{
+          id: '',
+          shortcode: '',
           element: 0,
           job: undefined,
           characters,
           weapons,
           summons
         }}
-        userGender={currentUser?.gender}
       />
 
       <div class="party-content">
diff --git a/src/routes/test/images/+page.svelte b/src/routes/test/images/+page.svelte
index 69bf1e91..1f8d1ed5 100644
--- a/src/routes/test/images/+page.svelte
+++ b/src/routes/test/images/+page.svelte
@@ -69,9 +69,9 @@
 
 	// Generated image URL
 	const imageUrl = $derived(
-		getImageUrl(resourceType, itemId || null, variant, {
+		getImageUrl(resourceType as ResourceType, itemId || null, variant as ImageVariant, {
 			pose: finalPose,
-			element: resourceType === 'weapon' && variant === 'grid' ? weaponElement : undefined
+			element: (resourceType as ResourceType) === 'weapon' && (variant as ImageVariant) === 'grid' ? weaponElement : undefined
 		})
 	)