From 106b2b8ee42a97b1aab35680194ed3155848c9e6 Mon Sep 17 00:00:00 2001
From: Justin Edmund <justin@jedmund.com>
Date: Mon, 5 Jun 2023 20:20:23 -0700
Subject: [PATCH] Update Select component

* data-placeholder style should match only if true
* Adjust corner radius to match cards instead of inputs
* Fix classNames call in SelectItem
---
 components/common/Select/index.scss    | 4 ++--
 components/common/SelectItem/index.tsx | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/components/common/Select/index.scss b/components/common/Select/index.scss
index 19426a62..b0d2566f 100644
--- a/components/common/Select/index.scss
+++ b/components/common/Select/index.scss
@@ -34,7 +34,7 @@
     cursor: not-allowed;
   }
 
-  &[data-placeholder] > span:not(.SelectIcon) {
+  &[data-placeholder='true'] > span:not(.SelectIcon) {
     color: var(--text-secondary);
   }
 
@@ -74,7 +74,7 @@
 
 .Select {
   background: var(--select-bg);
-  border-radius: $input-corner;
+  border-radius: $card-corner;
   border: $hover-stroke;
   box-shadow: $hover-shadow;
   padding: 0 $unit;
diff --git a/components/common/SelectItem/index.tsx b/components/common/SelectItem/index.tsx
index 60b3e4e3..79b7ddef 100644
--- a/components/common/SelectItem/index.tsx
+++ b/components/common/SelectItem/index.tsx
@@ -17,8 +17,8 @@ const SelectItem = React.forwardRef<HTMLDivElement, Props>(function selectItem(
   const { altText, iconSrc, ...rest } = props
   return (
     <Select.Item
-      className={classNames('SelectItem', props.className)}
       {...rest}
+      className={classNames({ SelectItem: true }, props.className)}
       ref={forwardedRef}
       value={`${value}`}
     >