granblue.team/hensei-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix edit sidebars to use pane stack push/pop

Browse source
This commit is contained in:
Justin Edmund 2025-12-03 16:33:16 -08:00
parent a02db87988
commit 122b07e827
1 changed files with 26 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
src/lib/features/details/openDetailsSidebar.svelte.ts
View file

@ -89,17 +89,9 @@ export function openWeaponEditSidebar(weapon: GridWeapon) {
const weaponName = getName(weapon.weapon) const weaponName = getName(weapon.weapon)
const title = weaponName !== 'Details' ? weaponName : 'Edit Weapon' const title = weaponName !== 'Details' ? weaponName : 'Edit Weapon'
// Get element for styling // Handler to go back to details view - uses pop() to return to previous pane
const element = getItemElement('weapon', weapon)
// Keep track of the current weapon state for going back to details
let currentWeapon = weapon
// Handler to go back to details view
const goBackToDetails = () => { const goBackToDetails = () => {
// Get the updated weapon from the store if available sidebar.pop()
const updated = partyStore.getWeapon(weapon.id)
openDetailsSidebar({ type: 'weapon', item: updated ?? currentWeapon })
} }
// Handler for save button - saves updates via partyStore // Handler for save button - saves updates via partyStore
@ -111,22 +103,24 @@ export function openWeaponEditSidebar(weapon: GridWeapon) {
} }
try { try {
const updated = await partyStore.updateWeapon(String(weapon.id), updates) await partyStore.updateWeapon(String(weapon.id), updates)
currentWeapon = updated
goBackToDetails() goBackToDetails()
} catch (error) { } catch (error) {
console.error('Failed to save weapon:', error) console.error('Failed to save weapon:', error)
// Still go back on error - the optimistic update will be visible
goBackToDetails() goBackToDetails()
} }
} }
sidebar.openWithComponent(title, EditWeaponSidebar, { // Push onto pane stack instead of replacing
weapon, sidebar.push({
onSave: handleSave, id: `edit-weapon-${weapon.id}`,
onCancel: goBackToDetails title,
}, { component: EditWeaponSidebar,
element, props: {
weapon,
onSave: handleSave,
onCancel: goBackToDetails
},
onback: goBackToDetails onback: goBackToDetails
}) })
} }
@ -135,17 +129,9 @@ export function openCharacterEditSidebar(character: GridCharacter) {
const characterName = getName(character.character) const characterName = getName(character.character)
const title = characterName !== 'Details' ? characterName : 'Edit Character' const title = characterName !== 'Details' ? characterName : 'Edit Character'
// Get element for styling // Handler to go back to details view - uses pop() to return to previous pane
const element = getItemElement('character', character)
// Keep track of the current character state for going back to details
let currentCharacter = character
// Handler to go back to details view
const goBackToDetails = () => { const goBackToDetails = () => {
// Get the updated character from the store if available sidebar.pop()
const updated = partyStore.getCharacter(character.id)
openDetailsSidebar({ type: 'character', item: updated ?? currentCharacter })
} }
// Handler for save button - saves updates via partyStore // Handler for save button - saves updates via partyStore
@ -157,22 +143,24 @@ export function openCharacterEditSidebar(character: GridCharacter) {
} }
try { try {
const updated = await partyStore.updateCharacter(String(character.id), updates) await partyStore.updateCharacter(String(character.id), updates)
currentCharacter = updated
goBackToDetails() goBackToDetails()
} catch (error) { } catch (error) {
console.error('Failed to save character:', error) console.error('Failed to save character:', error)
// Still go back on error - the optimistic update will be visible
goBackToDetails() goBackToDetails()
} }
} }
sidebar.openWithComponent(title, EditCharacterSidebar, { // Push onto pane stack instead of replacing
character, sidebar.push({
onSave: handleSave, id: `edit-character-${character.id}`,
onCancel: goBackToDetails title,
}, { component: EditCharacterSidebar,
element, props: {
character,
onSave: handleSave,
onCancel: goBackToDetails
},
onback: goBackToDetails onback: goBackToDetails
}) })
} }