From 16e24e337bd34db5f7b79c2639c6b2e2a131273c Mon Sep 17 00:00:00 2001
From: Justin Edmund <justin@jedmund.com>
Date: Fri, 28 Nov 2025 18:28:21 -0800
Subject: [PATCH] fix: correct function signatures and remove redundant code
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- DatabaseProvider.ts: Remove redundant normalizer check
  - Normalizer is applied by parent class, no need to apply twice
  - Fixes "Property 'normalizer' does not exist" error
- image.ts: Separate type and value exports for proper type resolution
- CharacterImageCell.svelte: Fix getCharacterImage parameter order
  - Changed (id, pose, variant) to (id, variant, pose)
- SearchContent.svelte: Fix getCharacterImage parameter order

Fixes ImageVariant type errors and property access errors.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 src/lib/components/database/cells/CharacterImageCell.svelte | 2 +-
 src/lib/components/sidebar/SearchContent.svelte             | 2 +-
 src/lib/features/database/detail/image.ts                   | 4 ++--
 src/lib/providers/DatabaseProvider.ts                       | 5 -----
 4 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/src/lib/components/database/cells/CharacterImageCell.svelte b/src/lib/components/database/cells/CharacterImageCell.svelte
index f1e3d543..7d89710b 100644
--- a/src/lib/components/database/cells/CharacterImageCell.svelte
+++ b/src/lib/components/database/cells/CharacterImageCell.svelte
@@ -12,7 +12,7 @@
 </script>
 
 <div class="image-cell">
-	<img src={getCharacterImage(row.granblueId, '01', 'square')} alt="" class="database-image" />
+	<img src={getCharacterImage(row.granblueId, 'square', '01')} alt="" class="database-image" />
 </div>
 
 <style lang="scss">
diff --git a/src/lib/components/sidebar/SearchContent.svelte b/src/lib/components/sidebar/SearchContent.svelte
index 20e27f0e..3f90b732 100644
--- a/src/lib/components/sidebar/SearchContent.svelte
+++ b/src/lib/components/sidebar/SearchContent.svelte
@@ -161,7 +161,7 @@
 
 		switch (type) {
 			case 'character':
-				return getCharacterImage(id, '01', 'square')
+				return getCharacterImage(id, 'square', '01')
 			case 'weapon':
 				return getWeaponImage(id, 'square')
 			case 'summon':
diff --git a/src/lib/features/database/detail/image.ts b/src/lib/features/database/detail/image.ts
index d0ee6362..8c369502 100644
--- a/src/lib/features/database/detail/image.ts
+++ b/src/lib/features/database/detail/image.ts
@@ -1,7 +1,5 @@
 // Re-export types and functions from the main image utility
 export {
-  type ResourceType as ResourceKind,
-  type ImageVariant,
   getPlaceholderImage as getPlaceholder,
   getCharacterImage,
   getWeaponImage,
@@ -9,6 +7,8 @@ export {
   getImageUrl as getImageUrlBase
 } from '$lib/utils/images'
 
+export type { ResourceType as ResourceKind, ImageVariant } from '$lib/utils/images'
+
 // Legacy compatibility wrapper
 interface ImageArgs {
   type: 'character' | 'weapon' | 'summon'
diff --git a/src/lib/providers/DatabaseProvider.ts b/src/lib/providers/DatabaseProvider.ts
index fb443249..dcf7b297 100644
--- a/src/lib/providers/DatabaseProvider.ts
+++ b/src/lib/providers/DatabaseProvider.ts
@@ -80,11 +80,6 @@ export class DatabaseProvider extends RestDataProvider {
 				}
 			}
 
-			// Apply normalizer if defined
-			if (this.normalizer && result.results) {
-				return result.results.map(this.normalizer)
-			}
-
 			return result.results || []
 		} catch (error) {
 			console.error('Failed to fetch data:', error)