granblue.team/hensei-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix infinite loop in SelectWithSelect

Browse source
This commit is contained in:
Justin Edmund 2023-01-19 07:25:19 -08:00
parent 6f3c7d2a03
commit 6064d726ce
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
components/SelectWithSelect/index.tsx
View file

@ -50,6 +50,7 @@ const SelectWithInput = ({
const [currentItemValue, setCurrentItemValue] = useState(rightSelectValue) const [currentItemValue, setCurrentItemValue] = useState(rightSelectValue)
// Hooks // Hooks
// if (currentItemSkill) sendValues(currentItemSkill.id, currentItemValue)
// Set default values from props // Set default values from props
useEffect(() => { useEffect(() => {
@ -57,10 +58,6 @@ const SelectWithInput = ({
setCurrentItemValue(rightSelectValue) setCurrentItemValue(rightSelectValue)
}, [leftSelectValue, rightSelectValue]) }, [leftSelectValue, rightSelectValue])
useEffect(() => {
if (currentItemSkill) sendValues(currentItemSkill.id, currentItemValue)
}, [currentItemSkill, currentItemValue])
// Methods: UI state management // Methods: UI state management
function changeOpen(side: 'left' | 'right') { function changeOpen(side: 'left' | 'right') {
if (side === 'left' && !leftSelectDisabled) { if (side === 'left' && !leftSelectDisabled) {
@ -120,6 +117,7 @@ const SelectWithInput = ({
function handleRightSelectChange(rawValue: string) { function handleRightSelectChange(rawValue: string) {
const value = parseFloat(rawValue) const value = parseFloat(rawValue)
setCurrentItemValue(value) setCurrentItemValue(value)
if (currentItemSkill) sendValues(currentItemSkill.id, value)
} }
return ( return (