From 6e0f0cace2d8c5ad833e9d2186d7265f4cc7ce8f Mon Sep 17 00:00:00 2001
From: Justin Edmund <justin@jedmund.com>
Date: Wed, 21 Jun 2023 02:18:19 -0700
Subject: [PATCH] Revert ChatGPT refactor of this method

Oops. This code was nice, but it didn't actually assign `false` to keys to be sent to the server. We will revisit this, but it needs to be fixed right now.

This fixes #325
---
 components/party/Party/index.tsx | 48 +++++++++++++-------------------
 1 file changed, 19 insertions(+), 29 deletions(-)

diff --git a/components/party/Party/index.tsx b/components/party/Party/index.tsx
index 27fbf291..90b4f0fb 100644
--- a/components/party/Party/index.tsx
+++ b/components/party/Party/index.tsx
@@ -145,37 +145,27 @@ const Party = (props: Props) => {
   function formatDetailsObject(details: DetailsObject) {
     const payload: { [key: string]: any } = {}
 
-    const mappings: { [key: string]: string } = {
-      name: 'name',
-      description: 'description',
-      chargeAttack: 'charge_attack',
-      fullAuto: 'full_auto',
-      autoGuard: 'auto_guard',
-      autoSummon: 'auto_summon',
-      clearTime: 'clear_time',
-      buttonCount: 'button_count',
-      chainCount: 'chain_count',
-      turnCount: 'turn_count',
-      extra: 'extra',
-      job: 'job_id',
-      guidebook1_id: 'guidebook1_id',
-      guidebook2_id: 'guidebook2_id',
-      guidebook3_id: 'guidebook3_id',
-    }
-
-    Object.entries(mappings).forEach(([key, value]) => {
-      if (details[key]) {
-        payload[value] = details[key]
-      }
-    })
-
+    if (details.name) payload.name = details.name
+    if (details.description) payload.description = details.description
     if (details.raid) payload.raid_id = details.raid.id
+    if (details.chargeAttack != undefined)
+      payload.charge_attack = details.chargeAttack
+    if (details.fullAuto != undefined) payload.full_auto = details.fullAuto
+    if (details.autoGuard != undefined) payload.auto_guard = details.autoGuard
+    if (details.autoSummon != undefined)
+      payload.auto_summon = details.autoSummon
+    if (details.clearTime) payload.clear_time = details.clearTime
+    if (details.buttonCount) payload.button_count = details.buttonCount
+    if (details.chainCount) payload.chain_count = details.chainCount
+    if (details.turnCount) payload.turn_count = details.turnCount
+    if (details.extra != undefined) payload.extra = details.extra
+    if (details.job) payload.job_id = details.job.id
+    if (details.guidebook1_id) payload.guidebook1_id = details.guidebook1_id
+    if (details.guidebook2_id) payload.guidebook2_id = details.guidebook2_id
+    if (details.guidebook3_id) payload.guidebook3_id = details.guidebook3_id
 
-    if (Object.keys(payload).length >= 1) {
-      return { party: payload }
-    } else {
-      return {}
-    }
+    if (Object.keys(payload).length >= 1) return { party: payload }
+    else return {}
   }
 
   function cancelAlert() {