From 9e999e4ec11f90cd60f47c5ad65e58c761a67cee Mon Sep 17 00:00:00 2001
From: Justin Edmund <justin@jedmund.com>
Date: Mon, 8 Jan 2024 04:05:41 -0800
Subject: [PATCH] Small refactor

---
 components/job/JobSection/index.tsx | 44 ++++++++++++++++-------------
 1 file changed, 25 insertions(+), 19 deletions(-)

diff --git a/components/job/JobSection/index.tsx b/components/job/JobSection/index.tsx
index 15a0ea13..44a4f21a 100644
--- a/components/job/JobSection/index.tsx
+++ b/components/job/JobSection/index.tsx
@@ -184,6 +184,30 @@ const JobSection = (props: Props) => {
     </div>
   )
 
+  const renderJobDropdown = () => {
+    if (props.editable) {
+      return (
+        <JobDropdown
+          currentJob={party.job?.id}
+          onChange={receiveJob}
+          ref={selectRef}
+        />
+      )
+    } else {
+      return (
+        <div className={styles.name}>
+          {party.job && (
+            <img
+              alt={party.job.name[locale]}
+              src={`${process.env.NEXT_PUBLIC_SIERO_IMG_URL}/job-icons/${party.job.granblue_id}.png`}
+            />
+          )}
+          <h3>{party.job ? party.job.name[locale] : t('no_job')}</h3>
+        </div>
+      )
+    }
+  }
+
   // Render: JSX components
   return (
     <section className={styles.job}>
@@ -196,25 +220,7 @@ const JobSection = (props: Props) => {
         onAccessorySelected={handleAccessorySelected}
       />
       <div className={styles.details}>
-        {props.editable ? (
-          <JobDropdown
-            currentJob={party.job?.id}
-            onChange={receiveJob}
-            ref={selectRef}
-          />
-        ) : (
-          <div className={styles.name}>
-            {party.job ? (
-              <img
-                alt={party.job.name[locale]}
-                src={`${process.env.NEXT_PUBLIC_SIERO_IMG_URL}/job-icons/${party.job.granblue_id}.png`}
-              />
-            ) : (
-              ''
-            )}
-            <h3>{party.job ? party.job.name[locale] : t('no_job')}</h3>
-          </div>
-        )}
+        {renderJobDropdown()}
 
         <ul className={skillContainerClasses}>
           {[...Array(numSkills)].map((e, i) => (