granblue.team/hensei-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use proper URL for job icons

Browse source 
Before we were linking to local icons, but these will live on S3
This commit is contained in:
Justin Edmund 2023-01-23 15:09:34 -08:00
parent 46ee8ac1e9
commit a4cc331f5e
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
components/JobDropdown/index.tsx
View file

@ -95,7 +95,7 @@ const JobDropdown = React.forwardRef<HTMLSelectElement, Props>(
key={i} key={i}
value={item.id} value={item.id}
altText={item.name[locale]} altText={item.name[locale]}
iconSrc={`/images/job-icons/${item.granblue_id}.png`} iconSrc={`${process.env.NEXT_PUBLIC_SIERO_IMG_URL}/job-icons/${item.granblue_id}.png`}
> >
{item.name[locale]} {item.name[locale]}
</SelectItem> </SelectItem>
@ -116,7 +116,9 @@ const JobDropdown = React.forwardRef<HTMLSelectElement, Props>(
value={currentJob ? currentJob.id : 'no-job'} value={currentJob ? currentJob.id : 'no-job'}
altText={currentJob ? currentJob.name[locale] : ''} altText={currentJob ? currentJob.name[locale] : ''}
iconSrc={ iconSrc={
currentJob ? `/images/job-icons/${currentJob.granblue_id}.png` : '' currentJob
? `${process.env.NEXT_PUBLIC_SIERO_IMG_URL}/job-icons/${currentJob.granblue_id}.png`
: ''
} }
open={open} open={open}
onClick={openJobSelect} onClick={openJobSelect}

2
components/JobSection/index.tsx
View file

@ -149,7 +149,7 @@ const JobSection = (props: Props) => {
<div className="JobName"> <div className="JobName">
<img <img
alt={party.job.name[locale]} alt={party.job.name[locale]}
src={`/images/job-icons/${party.job.granblue_id}.png`} src={`${process.env.NEXT_PUBLIC_SIERO_IMG_URL}/job-icons/${party.job.granblue_id}.png`}
/> />
<h3>{party.job ? party.job.name[locale] : t('no_job')}</h3> <h3>{party.job ? party.job.name[locale] : t('no_job')}</h3>
</div> </div>