diff --git a/components/GridRep/index.tsx b/components/GridRep/index.tsx index 9448bcde..9aa1df52 100644 --- a/components/GridRep/index.tsx +++ b/components/GridRep/index.tsx @@ -22,7 +22,7 @@ interface Props { createdAt: Date displayUser?: boolean | false onClick: (shortcode: string) => void - onSave: (partyId: string, favorited: boolean) => void + onSave?: (partyId: string, favorited: boolean) => void } const GridRep = (props: Props) => { @@ -75,7 +75,8 @@ const GridRep = (props: Props) => { } function sendSaveData() { - props.onSave(props.id, props.favorited) + if (props.onSave) + props.onSave(props.id, props.favorited) } const userImage = () => { diff --git a/components/RaidDropdown/index.tsx b/components/RaidDropdown/index.tsx index 5e4c032c..5fe72268 100644 --- a/components/RaidDropdown/index.tsx +++ b/components/RaidDropdown/index.tsx @@ -45,7 +45,7 @@ const RaidDropdown = React.forwardRef(function useFiel useEffect(() => { fetchRaids() - }, []) + }, [fetchRaids]) function fetchRaids() { api.endpoints.raids.getAll(headers) diff --git a/pages/[username].tsx b/pages/[username].tsx index b48103da..eba50ebd 100644 --- a/pages/[username].tsx +++ b/pages/[username].tsx @@ -72,11 +72,13 @@ const ProfileRoute: React.FC = () => { { parties.map((party, i) => { return diff --git a/pages/saved.tsx b/pages/saved.tsx index 939c5d56..17de5857 100644 --- a/pages/saved.tsx +++ b/pages/saved.tsx @@ -26,7 +26,7 @@ const SavedRoute: React.FC = () => { useEffect(() => { console.log(`Fetching favorite teams...`) fetchTeams() - }, []) + }, [fetchTeams]) useEffect(() => { window.addEventListener("scroll", handleScroll) @@ -145,7 +145,7 @@ const SavedRoute: React.FC = () => { function renderNoGrids() { return (
-

You haven't saved any teams yet

+

You haven't saved any teams yet

) } diff --git a/pages/teams.tsx b/pages/teams.tsx index c077f778..5fcc6b6f 100644 --- a/pages/teams.tsx +++ b/pages/teams.tsx @@ -26,7 +26,7 @@ const TeamsRoute: React.FC = () => { useEffect(() => { console.log(`Fetching teams...`) fetchTeams() - }, []) + }, [fetchTeams]) useEffect(() => { window.addEventListener("scroll", handleScroll)