From b54ac91638eb8d4eadd153d856801d7d8b907817 Mon Sep 17 00:00:00 2001 From: Justin Edmund Date: Fri, 28 Nov 2025 18:26:18 -0800 Subject: [PATCH] fix: correct type comparison errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - jobUtils.ts: Remove string comparison for job.row (row is typed as number) - job.row === '1' comparison is always false, removed - grid.service.ts: Fix swap operation to compare position with position - Changed i.id === operation.targetPosition to i.position === operation.targetPosition - targetPosition is a number (position), not a string (id) Fixes "This comparison appears to be unintentional because the types have no overlap" errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- src/lib/services/grid.service.ts | 2 +- src/lib/utils/jobUtils.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/services/grid.service.ts b/src/lib/services/grid.service.ts index fadb1c2a..2f9701b5 100644 --- a/src/lib/services/grid.service.ts +++ b/src/lib/services/grid.service.ts @@ -574,7 +574,7 @@ export class GridService { case 'swap': const item1 = updated.find(i => i.id === operation.itemId) - const item2 = updated.find(i => i.id === operation.targetPosition) + const item2 = updated.find(i => i.position === operation.targetPosition) if (item1 && item2) { const tempPos = item1.position item1.position = item2.position diff --git a/src/lib/utils/jobUtils.ts b/src/lib/utils/jobUtils.ts index ac9e6e68..0d285f7a 100644 --- a/src/lib/utils/jobUtils.ts +++ b/src/lib/utils/jobUtils.ts @@ -123,7 +123,7 @@ export function jobSupportsAccessories(job: Job | undefined): boolean { */ export function getJobSkillSlotCount(job: Job | undefined): number { if (!job) return 0 - return job.row === 1 || job.row === '1' ? 3 : 4 + return job.row === 1 ? 3 : 4 } /** @@ -253,7 +253,7 @@ export function validateSkillConfiguration( } // Check for Row 1 constraint - if ((job.row === 1 || job.row === '1') && skills[3]) { + if (job.row === 1 && skills[3]) { errors.push('Row I jobs only support 3 skill slots') }