granblue.team/hensei-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #107 from jedmund/performance-fixes

Browse source 
Browser performance fixes
This commit is contained in:
Justin Edmund 2023-01-02 01:49:16 -08:00 committed by GitHub
commit b67845f4e7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 3610 additions and 5151 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
components/Input/index.tsx
View file

@ -8,13 +8,13 @@ interface Props
React.InputHTMLAttributes<HTMLInputElement>, React.InputHTMLAttributes<HTMLInputElement>,
HTMLInputElement HTMLInputElement
> { > {
visible?: boolean visible?: string
error?: string error?: string
label?: string label?: string
} }
const defaultProps = { const defaultProps = {
visible: true, visible: 'true',
} }
const Input = React.forwardRef<HTMLInputElement, Props>(function Input( const Input = React.forwardRef<HTMLInputElement, Props>(function Input(

9
components/JobSection/index.tsx
View file

@ -1,4 +1,4 @@
import React, { ForwardedRef, useEffect, useState } from 'react' import React, { useEffect, useState } from 'react'
import { useRouter } from 'next/router' import { useRouter } from 'next/router'
import { useSnapshot } from 'valtio' import { useSnapshot } from 'valtio'
import { useTranslation } from 'next-i18next' import { useTranslation } from 'next-i18next'
@ -8,7 +8,6 @@ import JobSkillItem from '~components/JobSkillItem'
import SearchModal from '~components/SearchModal' import SearchModal from '~components/SearchModal'
import { appState } from '~utils/appState' import { appState } from '~utils/appState'
import type { JobSkillObject, SearchableObject } from '~types' import type { JobSkillObject, SearchableObject } from '~types'
import './index.scss' import './index.scss'
@ -132,7 +131,11 @@ const JobSection = (props: Props) => {
return ( return (
<section id="Job"> <section id="Job">
<div className="JobImage"> <div className="JobImage">
<img src={imageUrl} /> {party.job && party.job.id !== '-1' ? (
<img alt={party.job.name[locale]} src={imageUrl} />
) : (
''
)}
<div className="Overlay" /> <div className="Overlay" />
</div> </div>
<div className="JobDetails"> <div className="JobDetails">

1
components/JobSkillSearchFilterBar/index.tsx
View file

@ -18,6 +18,7 @@ const JobSkillSearchFilterBar = (props: Props) => {
const [currentGroup, setCurrentGroup] = useState(-1) const [currentGroup, setCurrentGroup] = useState(-1)
function openSelect() { function openSelect() {
// debugger
setOpen(!open) setOpen(!open)
} }

11
components/Overlay/index.tsx
View file

@ -11,13 +11,16 @@ const defaultProps = {
visible: true, visible: true,
} }
const Overlay = ({ const Overlay = React.forwardRef<HTMLDivElement, Props>(function Overlay(
{
visible: displayed, visible: displayed,
open, open,
}: { }: {
visible: boolean visible: boolean
open: boolean open: boolean
}) => { },
forwardedRef
) {
const [visible, setVisible] = useState(open) const [visible, setVisible] = useState(open)
const classes = classNames({ const classes = classNames({
@ -43,7 +46,7 @@ const Overlay = ({
} }
return visible ? <div className={classes} onClick={handleClick} /> : null return visible ? <div className={classes} onClick={handleClick} /> : null
} })
Overlay.defaultProps = defaultProps Overlay.defaultProps = defaultProps

8814
package-lock.json generated
View file

File diff suppressed because it is too large Load diff

12
package.json
View file

@ -11,14 +11,14 @@
"lint": "next lint" "lint": "next lint"
}, },
"dependencies": { "dependencies": {
"@radix-ui/react-alert-dialog": "^0.1.5", "@radix-ui/react-alert-dialog": "^1.0.2",
"@radix-ui/react-dialog": "^0.1.5", "@radix-ui/react-dialog": "^1.0.2",
"@radix-ui/react-dropdown-menu": "^0.1.6", "@radix-ui/react-dropdown-menu": "^2.0.1",
"@radix-ui/react-hover-card": "^0.1.5", "@radix-ui/react-hover-card": "^1.0.2",
"@radix-ui/react-select": "^1.1.2", "@radix-ui/react-select": "^1.1.2",
"@radix-ui/react-switch": "^0.1.5", "@radix-ui/react-switch": "^1.0.1",
"@radix-ui/react-toast": "^1.1.2", "@radix-ui/react-toast": "^1.1.2",
"@radix-ui/react-toggle-group": "^0.1.5", "@radix-ui/react-toggle-group": "^1.0.1",
"@svgr/webpack": "^6.2.0", "@svgr/webpack": "^6.2.0",
"axios": "^0.25.0", "axios": "^0.25.0",
"classnames": "^2.3.1", "classnames": "^2.3.1",