Fix tap targets in header menu

This commit is contained in:
Justin Edmund 2022-02-23 15:16:31 -08:00
parent 06eef3c248
commit d688ade570
3 changed files with 21 additions and 6 deletions

View file

@ -8,7 +8,9 @@ const AboutModal = () => {
return ( return (
<Dialog.Root> <Dialog.Root>
<Dialog.Trigger asChild> <Dialog.Trigger asChild>
<li className="MenuItem">About</li> <li className="MenuItem">
<span>About</span>
</li>
</Dialog.Trigger> </Dialog.Trigger>
<Dialog.Portal> <Dialog.Portal>
<Dialog.Content className="About Dialog" onOpenAutoFocus={ (event) => event.preventDefault() }> <Dialog.Content className="About Dialog" onOpenAutoFocus={ (event) => event.preventDefault() }>

View file

@ -11,7 +11,6 @@
.MenuItem { .MenuItem {
color: $grey-10; color: $grey-10;
font-weight: $normal; font-weight: $normal;
padding: 12px;
&:hover { &:hover {
background: $grey-100; background: $grey-100;
@ -26,6 +25,11 @@
a { a {
color: $grey-10; color: $grey-10;
} }
a, span {
display: block;
padding: 12px;
}
} }
.MenuGroup { .MenuGroup {

View file

@ -47,8 +47,12 @@ const HeaderMenu = (props: Props) => {
</div> </div>
<div className="MenuGroup"> <div className="MenuGroup">
<AboutModal /> <AboutModal />
<li className="MenuItem">Settings</li> <li className="MenuItem">
<li className="MenuItem" onClick={props.logout}>Logout</li> <span>Settings</span>
</li>
<li className="MenuItem" onClick={props.logout}>
<span>Logout</span>
</li>
</div> </div>
</ul> </ul>
</nav> </nav>
@ -71,13 +75,18 @@ const HeaderMenu = (props: Props) => {
</li> </li>
</div> </div>
<div className="MenuGroup"> <div className="MenuGroup">
<li className="MenuItem" onClick={openLoginModal}>Log in</li> <li className="MenuItem" onClick={openLoginModal}>
<span>Log in</span>
</li>
{loginOpen ? ( {loginOpen ? (
<LoginModal <LoginModal
close={closeLoginModal} close={closeLoginModal}
/> />
) : null} ) : null}
<li className="MenuItem" onClick={openSignupModal}>Sign up</li>
<li className="MenuItem" onClick={openSignupModal}>
<span>Sign up</span>
</li>
{signupOpen ? ( {signupOpen ? (
<SignupModal <SignupModal
close={closeSignupModal} close={closeSignupModal}