From e0810781f4891230dc9feb9eb2cbc3b7204b4036 Mon Sep 17 00:00:00 2001
From: Justin Edmund <justin@jedmund.com>
Date: Fri, 28 Nov 2025 20:04:02 -0800
Subject: [PATCH] fix: Phase 7d - fix null/undefined handling (28 -> 24 errors)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixed multiple null/undefined type errors by adding proper null checks
and default values.

Changes:
1. CharacterRep.svelte:
   - Changed import from '$lib/types/enums' to '$lib/utils/element'
   - getElementClass in utils/element accepts undefined, enums version doesn't

2. ItemHeader.svelte:
   - Convert null to undefined for gridUncapLevel and gridTranscendence
   - getCharacterPose expects 'number | undefined', not 'number | null | undefined'

3. UncapStatusDisplay.svelte:
   - Added null coalescing for transcendenceStep check
   - Changed from `transcendenceStep > 0` to `(transcendenceStep ?? 0) > 0`

4. base.adapter.ts:
   - Provide default no-op function for optional onError callback
   - Required<AdapterOptions> needs all properties defined

Result: 28 → 24 errors (-4)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 src/lib/api/adapters/base.adapter.ts                            | 2 +-
 src/lib/components/reps/CharacterRep.svelte                     | 2 +-
 src/lib/components/sidebar/details/ItemHeader.svelte            | 2 +-
 .../components/sidebar/modifications/UncapStatusDisplay.svelte  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/api/adapters/base.adapter.ts b/src/lib/api/adapters/base.adapter.ts
index b97cfb5d..248f2d27 100644
--- a/src/lib/api/adapters/base.adapter.ts
+++ b/src/lib/api/adapters/base.adapter.ts
@@ -68,7 +68,7 @@ export abstract class BaseAdapter {
 			timeout: options.timeout ?? 30000,
 			retries: options.retries ?? 3,
 			cacheTime: options.cacheTime ?? 0,
-			onError: options.onError
+			onError: options.onError ?? (() => {})
 		}
 	}
 
diff --git a/src/lib/components/reps/CharacterRep.svelte b/src/lib/components/reps/CharacterRep.svelte
index acb49caf..7108443f 100644
--- a/src/lib/components/reps/CharacterRep.svelte
+++ b/src/lib/components/reps/CharacterRep.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
 	import type { Party, GridWeapon, GridCharacter } from '$lib/types/api/party'
 	import type { Job } from '$lib/types/api/entities'
-	import { getElementClass } from '$lib/types/enums'
+	import { getElementClass } from '$lib/utils/element'
 	import { getCharacterImageWithPose } from '$lib/utils/images'
 	import { getJobPortraitUrl, Gender } from '$lib/utils/jobUtils'
 
diff --git a/src/lib/components/sidebar/details/ItemHeader.svelte b/src/lib/components/sidebar/details/ItemHeader.svelte
index d422801a..586d3682 100644
--- a/src/lib/components/sidebar/details/ItemHeader.svelte
+++ b/src/lib/components/sidebar/details/ItemHeader.svelte
@@ -23,7 +23,7 @@
 		const id = itemData?.granblueId
 
 		if (type === 'character') {
-			const pose = getCharacterPose(gridUncapLevel, gridTranscendence)
+			const pose = getCharacterPose(gridUncapLevel ?? undefined, gridTranscendence ?? undefined)
 			return getCharacterDetailImage(id, pose)
 		} else if (type === 'weapon') {
 			return getWeaponBaseImage(id)
diff --git a/src/lib/components/sidebar/modifications/UncapStatusDisplay.svelte b/src/lib/components/sidebar/modifications/UncapStatusDisplay.svelte
index 7bc7b37f..aab5d687 100644
--- a/src/lib/components/sidebar/modifications/UncapStatusDisplay.svelte
+++ b/src/lib/components/sidebar/modifications/UncapStatusDisplay.svelte
@@ -92,7 +92,7 @@
           <span class="badge" class:active={(uncapLevel ?? 0) >= 5}>ULB</span>
         {/if}
         {#if transcendence}
-          <span class="badge" class:active={transcendenceStep > 0}>Trans</span>
+          <span class="badge" class:active={(transcendenceStep ?? 0) > 0}>Trans</span>
         {/if}
         {#if !flb && !ulb && !transcendence}
           <span class="badge standard">Standard</span>