Commit graph

4 commits

Author SHA1 Message Date
devin-ai-integration[bot]
9504dd7003
Fix type errors: PartyService constructor, PaginatedResponse.per, remove broken tests (#440)
## Summary

This PR fixes several pre-existing type errors identified by
`svelte-check`:

1. **PartyService constructor** - Removed unused `fetch` argument from
constructor call in `teams/[id]/+page.server.ts`. The `PartyService`
class has an empty constructor that doesn't accept any parameters.

2. **PaginatedResponse property** - Changed `response.per` to
`response.perPage` in `teams/explore/+page.server.ts` to match the
`PaginatedResponse<T>` type definition.

3. **Broken test files** - Removed 3 test files that were importing
non-existent `actions` exports:
   - `database/characters/[id]/page.server.test.ts`
   - `database/summons/[id]/page.server.test.ts`
   - `database/weapons/[id]/page.server.test.ts`

These tests were testing SvelteKit form actions that don't exist in the
corresponding `+page.server.ts` files.

Reduces `svelte-check` errors from 419 to 366 (-53 errors).

## Review & Testing Checklist for Human

- [ ] **Verify party loading works** - Navigate to `/teams/[shortcode]`
and confirm party data loads correctly. The `PartyService` now uses
`partyAdapter` directly without a custom fetch function - verify this
works on both client and server.
- [ ] **Verify explore pagination** - Navigate to `/teams/explore` and
confirm pagination displays correctly (page count, items per page).
- [ ] **Confirm deleted tests were not needed** - The removed tests were
for form actions (`actions.save`) that don't exist. Verify there's no
plan to implement these actions soon, or if there is, the tests should
be re-added when the actions are implemented.

### Notes

The deleted test files were testing functionality that doesn't exist -
they imported `actions` from page.server.ts files that only export
`load` functions, not form actions. If database entity editing via form
actions is planned, new tests should be written when that functionality
is implemented.

Link to Devin run:
https://app.devin.ai/sessions/611580bc2db94e20a48c3692d3cbd432
Requested by: Justin Edmund (justin@jedmund.com) / @jedmund

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Justin Edmund <justin@jedmund.com>
2025-11-28 11:26:01 -08:00
0c03332988 update ui components for better interaction 2025-09-23 22:09:39 -07:00
100a04eda6 Fix adapter field names and runed import
- Update Party interface to use transformed field names (weapons/characters/summons)
- Fix runed import to use useDebounce instead of debounced
- Clean up debug logging
2025-09-20 02:26:54 -07:00
65411ad2ae Migrate teams route from [shortcode] to [id] 2025-09-15 04:03:52 -07:00