Justin Edmund
426645813e
## Summary - Fixes periodic production crashes (undici ECONNREFUSED ::1) by bounding server cache size/lifetime and hardening server HTTP client. ### Root cause - React server cache (cache(...)) held axios responses indefinitely across many parameter combinations, causing slow memory growth until the Next.js app router worker was OOM-killed. The main server then failed IPC to the worker (ECONNREFUSED ::1:<port>). ### Changes - `app/lib/data.ts`: Replace unbounded cache(...) with unstable_cache and explicit keys; TTLs: 60s for teams/detail/favorites/user, 300s for meta (jobs/skills/accessories/raids/version). - `app/lib/api-utils.ts`: Add shared Axios instance with 15s timeout and keepAlive http/https agents; apply to GET/POST/PUT/DELETE helpers. - `pages/api/preview/[shortcode].ts`: Remove duplicate handler to dedupe route; retain the .tsx variant using `NEXT_PUBLIC_SIERO_API_URL`. ### Notes - Build currently has pre-existing app/pages route duplication errors; out of scope here but unrelated to this fix. - Ensure `NEXT_PUBLIC_SIERO_API_URL` and `NEXT_PUBLIC_SIERO_OAUTH_URL` are set on Railway. ### Risk/impact - Low risk; behavior is unchanged aside from bounded caching and resilient HTTP. - Cache TTLs can be tuned later if needed. ### Test plan - Verify saved/teams/user pages load and revalidate after TTL. - Validate API routes still proxy correctly; timeouts occur after ~15s for hung upstreams. - Monitor memory over several days; expect stable usage without steady growth.
89 lines
No EOL
2.3 KiB
TypeScript
89 lines
No EOL
2.3 KiB
TypeScript
import { NextRequest, NextResponse } from 'next/server';
|
|
import { z } from 'zod';
|
|
import { fetchFromApi, putToApi, deleteFromApi, revalidate, PartySchema } from '~/app/lib/api-utils';
|
|
|
|
// GET handler for fetching a single party by shortcode
|
|
export async function GET(
|
|
request: NextRequest,
|
|
{ params }: { params: { shortcode: string } }
|
|
) {
|
|
try {
|
|
const { shortcode } = params;
|
|
|
|
// Fetch party data
|
|
const data = await fetchFromApi(`/parties/${shortcode}`);
|
|
|
|
return NextResponse.json(data);
|
|
} catch (error: any) {
|
|
console.error(`Error fetching party with shortcode ${params.shortcode}`, error);
|
|
return NextResponse.json(
|
|
{ error: error.message || 'Failed to fetch party' },
|
|
{ status: error.response?.status || 500 }
|
|
);
|
|
}
|
|
}
|
|
|
|
// Update party schema
|
|
const UpdatePartySchema = PartySchema.extend({
|
|
id: z.string().optional(),
|
|
shortcode: z.string().optional(),
|
|
});
|
|
|
|
// PUT handler for updating a party
|
|
export async function PUT(
|
|
request: NextRequest,
|
|
{ params }: { params: { shortcode: string } }
|
|
) {
|
|
try {
|
|
const { shortcode } = params;
|
|
const body = await request.json();
|
|
|
|
// Validate the request body
|
|
const validatedData = UpdatePartySchema.parse(body.party);
|
|
|
|
// Update the party
|
|
const response = await putToApi(`/parties/${shortcode}`, {
|
|
party: validatedData
|
|
});
|
|
|
|
// Revalidate the party page
|
|
revalidate(`/p/${shortcode}`);
|
|
|
|
return NextResponse.json(response);
|
|
} catch (error: any) {
|
|
if (error instanceof z.ZodError) {
|
|
return NextResponse.json(
|
|
{ error: 'Validation error', details: error.errors },
|
|
{ status: 400 }
|
|
);
|
|
}
|
|
|
|
return NextResponse.json(
|
|
{ error: error.message || 'Failed to update party' },
|
|
{ status: error.response?.status || 500 }
|
|
);
|
|
}
|
|
}
|
|
|
|
// DELETE handler for deleting a party
|
|
export async function DELETE(
|
|
request: NextRequest,
|
|
{ params }: { params: { shortcode: string } }
|
|
) {
|
|
try {
|
|
const { shortcode } = params;
|
|
|
|
// Delete the party
|
|
const response = await deleteFromApi(`/parties/${shortcode}`);
|
|
|
|
// Revalidate related pages
|
|
revalidate(`/teams`);
|
|
|
|
return NextResponse.json(response);
|
|
} catch (error: any) {
|
|
return NextResponse.json(
|
|
{ error: error.message || 'Failed to delete party' },
|
|
{ status: error.response?.status || 500 }
|
|
);
|
|
}
|
|
} |