Justin Edmund
426645813e
## Summary - Fixes periodic production crashes (undici ECONNREFUSED ::1) by bounding server cache size/lifetime and hardening server HTTP client. ### Root cause - React server cache (cache(...)) held axios responses indefinitely across many parameter combinations, causing slow memory growth until the Next.js app router worker was OOM-killed. The main server then failed IPC to the worker (ECONNREFUSED ::1:<port>). ### Changes - `app/lib/data.ts`: Replace unbounded cache(...) with unstable_cache and explicit keys; TTLs: 60s for teams/detail/favorites/user, 300s for meta (jobs/skills/accessories/raids/version). - `app/lib/api-utils.ts`: Add shared Axios instance with 15s timeout and keepAlive http/https agents; apply to GET/POST/PUT/DELETE helpers. - `pages/api/preview/[shortcode].ts`: Remove duplicate handler to dedupe route; retain the .tsx variant using `NEXT_PUBLIC_SIERO_API_URL`. ### Notes - Build currently has pre-existing app/pages route duplication errors; out of scope here but unrelated to this fix. - Ensure `NEXT_PUBLIC_SIERO_API_URL` and `NEXT_PUBLIC_SIERO_OAUTH_URL` are set on Railway. ### Risk/impact - Low risk; behavior is unchanged aside from bounded caching and resilient HTTP. - Cache TTLs can be tuned later if needed. ### Test plan - Verify saved/teams/user pages load and revalidate after TTL. - Validate API routes still proxy correctly; timeouts occur after ~15s for hung upstreams. - Monitor memory over several days; expect stable usage without steady growth.
80 lines
No EOL
2.3 KiB
TypeScript
80 lines
No EOL
2.3 KiB
TypeScript
import { NextRequest, NextResponse } from 'next/server';
|
|
import { z } from 'zod';
|
|
import { fetchFromApi, postToApi, PartySchema } from '~/app/lib/api-utils';
|
|
|
|
// GET handler for fetching parties with filters
|
|
export async function GET(request: NextRequest) {
|
|
try {
|
|
// Parse URL parameters
|
|
const searchParams = request.nextUrl.searchParams;
|
|
const element = searchParams.get('element');
|
|
const raid = searchParams.get('raid');
|
|
const recency = searchParams.get('recency');
|
|
const page = searchParams.get('page') || '1';
|
|
const username = searchParams.get('username');
|
|
|
|
// Build query parameters
|
|
const queryParams: Record<string, string> = {};
|
|
if (element) queryParams.element = element;
|
|
if (raid) queryParams.raid_id = raid;
|
|
if (recency) queryParams.recency = recency;
|
|
if (page) queryParams.page = page;
|
|
|
|
let endpoint = '/parties';
|
|
|
|
// If username is provided, fetch that user's parties
|
|
if (username) {
|
|
endpoint = `/users/${username}/parties`;
|
|
}
|
|
|
|
// Append query parameters
|
|
const queryString = new URLSearchParams(queryParams).toString();
|
|
if (queryString) {
|
|
endpoint += `?${queryString}`;
|
|
}
|
|
|
|
const data = await fetchFromApi(endpoint);
|
|
|
|
return NextResponse.json(data);
|
|
} catch (error: any) {
|
|
console.error('Error fetching parties', error);
|
|
return NextResponse.json(
|
|
{ error: error.message || 'Failed to fetch parties' },
|
|
{ status: error.response?.status || 500 }
|
|
);
|
|
}
|
|
}
|
|
|
|
// Validate party data
|
|
const CreatePartySchema = PartySchema.extend({
|
|
element: z.number().min(1).max(6),
|
|
raid_id: z.string().optional(),
|
|
});
|
|
|
|
// POST handler for creating a new party
|
|
export async function POST(request: NextRequest) {
|
|
try {
|
|
const body = await request.json();
|
|
|
|
// Validate the request body
|
|
const validatedData = CreatePartySchema.parse(body.party);
|
|
|
|
const response = await postToApi('/parties', {
|
|
party: validatedData
|
|
});
|
|
|
|
return NextResponse.json(response);
|
|
} catch (error: any) {
|
|
if (error instanceof z.ZodError) {
|
|
return NextResponse.json(
|
|
{ error: 'Validation error', details: error.errors },
|
|
{ status: 400 }
|
|
);
|
|
}
|
|
|
|
return NextResponse.json(
|
|
{ error: error.message || 'Failed to create party' },
|
|
{ status: error.response?.status || 500 }
|
|
);
|
|
}
|
|
} |