jedmund/jedmund-svelte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(admin): remove infinite loop in navigation guards

Browse source 
Fixed infinite loop caused by calling goto() inside beforeNavigate,
which would trigger the same navigation guard again.

The correct approach is to NOT cancel navigation, but simply await
the autosave flush. SvelteKit's beforeNavigate accepts async callbacks,
so navigation will naturally wait for the flush to complete before
proceeding.

Changes:
- Removed navigation.cancel() calls
- Removed goto() calls that created the loop
- Simply await autoSave.flush() and let navigation proceed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Justin Edmund 2025-10-07 18:43:28 -07:00
parent 8fa26fb39e
commit 128a24ccde
5 changed files with 5 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/lib/components/admin/EssayForm.svelte
View file

@ -170,13 +170,9 @@ $effect(() => {
if (autoSave.status === 'saved') {
return
}
navigation.cancel()
// Flush any pending changes before allowing navigation to proceed
try {
await autoSave.flush()
// Navigate to the intended destination after flush completes
if (navigation.to?.url) {
goto(navigation.to.url.pathname + navigation.to.url.search)
}
} catch (error) {
console.error('Autosave flush failed:', error)
}

6
src/lib/components/admin/PhotoPostForm.svelte
View file

@ -174,13 +174,9 @@ $effect(() => {
if (autoSave.status === 'saved') {
return
}
navigation.cancel()
// Flush any pending changes before allowing navigation to proceed
try {
await autoSave.flush()
// Navigate to the intended destination after flush completes
if (navigation.to?.url) {
goto(navigation.to.url.pathname + navigation.to.url.search)
}
} catch (error) {
console.error('Autosave flush failed:', error)
}

7
src/lib/components/admin/ProjectForm.svelte
View file

@ -185,14 +185,9 @@
return
}
// Otherwise, flush any pending changes before navigating
navigation.cancel()
// Otherwise, flush any pending changes before allowing navigation to proceed
try {
await autoSave.flush()
// Navigate to the intended destination after flush completes
if (navigation.to?.url) {
goto(navigation.to.url.pathname + navigation.to.url.search)
}
} catch (error) {
console.error('Autosave flush failed:', error)
toast.error('Failed to save changes')

6
src/lib/components/admin/SimplePostForm.svelte
View file

@ -175,13 +175,9 @@ beforeNavigate(async (navigation) => {
if (autoSave.status === 'saved') {
return
}
navigation.cancel()
// Flush any pending changes before allowing navigation to proceed
try {
await autoSave.flush()
// Navigate to the intended destination after flush completes
if (navigation.to?.url) {
goto(navigation.to.url.pathname + navigation.to.url.search)
}
} catch (error) {
console.error('Autosave flush failed:', error)
}

7
src/routes/admin/posts/[id]/edit/+page.svelte
View file

@ -386,14 +386,9 @@ onMount(async () => {
return
}
// Otherwise, flush any pending changes before navigating
navigation.cancel()
// Otherwise, flush any pending changes before allowing navigation to proceed
try {
await autoSave.flush()
// Navigate to the intended destination after flush completes
if (navigation.to?.url) {
goto(navigation.to.url.pathname + navigation.to.url.search)
}
} catch (error) {
console.error('Autosave flush failed:', error)
}