granblue.team/hensei-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix race condition

Browse source
This commit is contained in:
Justin Edmund 2022-12-03 13:55:41 -08:00
parent b93d0dd366
commit 27d31d61c0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/api/v1/jobs_controller.rb
View file

@ -11,7 +11,6 @@ class Api::V1::JobsController < Api::V1::ApiController
# Extract job and find its main skills # Extract job and find its main skills
job = Job.find(job_params[:job_id]) job = Job.find(job_params[:job_id])
main_skills = JobSkill.where(job: job.id, main: true) main_skills = JobSkill.where(job: job.id, main: true)
# Update the party # Update the party
@ -22,7 +21,8 @@ class Api::V1::JobsController < Api::V1::ApiController
# Check for incompatible Base and EMP skills # Check for incompatible Base and EMP skills
%w[skill1_id skill2_id skill3_id].each do |key| %w[skill1_id skill2_id skill3_id].each do |key|
@party[key] = nil if mismatched_skill(@party.job, JobSkill.find(@party[key])) ap "In here with #{key}"
@party[key] = nil if @party[key] && mismatched_skill(@party.job, JobSkill.find(@party[key]))
end end
render :update, status: :ok if @party.save! render :update, status: :ok if @party.save!