Add GranblueError and move app errors to extend it

app/controllers/api/v1/api_controller.rb

@@ -16,7 +16,7 @@ module Api::V1
     rescue_from Api::V1::UnauthorizedError, with: :render_unauthorized_response
     rescue_from ActionController::ParameterMissing, with: :render_unprocessable_entity_response
 
-    rescue_from StandardError do |e|
+    rescue_from GranblueError do |e|
       render_error(e)
     end
 
@@ -50,7 +50,11 @@ module Api::V1
 
     ### Error response methods
     def render_error(error)
-      render action: 'errors', json: error.to_hash, status: error.http_status
+      if error
+        render action: 'errors', json: error.to_hash, status: error.http_status
+      else
+        render action: 'errors'
+      end
     end
 
     def render_unprocessable_entity_response(exception)

app/errors/api/v1/FavoriteAlreadyExistsError.rb

@@ -1,22 +1,22 @@
 module Api::V1
-    class FavoriteAlreadyExistsError < StandardError
+  class FavoriteAlreadyExistsError < GranblueError
-        def http_status
+    def http_status
-            422
+      422
-        end
-
-        def code
-            "favorite_already_exists"
-        end
-
-        def message
-            "This user has favorited this party already"
-        end
-
-        def to_hash
-            {
-                message: message,
-                code: code
-            }
-        end
     end
+
+    def code
+      "favorite_already_exists"
+    end
+
+    def message
+      "This user has favorited this party already"
+    end
+
+    def to_hash
+      {
+        message: message,
+        code: code
+      }
+    end
+  end
 end

app/errors/api/v1/GranblueError.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module Api
+  module V1
+    # This is the base error that we inherit from for application errors
+    class GranblueError < StandardError
+      def initialize(data)
+        @data = data
+      end
+
+      def http_status
+        422
+      end
+
+      def code
+        'granblue_error'
+      end
+
+      def message
+        'Something went wrong'
+      end
+
+      def to_hash
+        {
+          message: message,
+          code: code
+        }
+      end
+    end
+  end
+end

app/errors/api/v1/IncompatibleSkillError.rb

@@ -1,5 +1,5 @@
 module Api::V1
-  class IncompatibleSkillError < StandardError
+  class IncompatibleSkillError < GranblueError
     def initialize(data)
       @data = data
     end

app/errors/api/v1/NoJobProvidedError.rb

@@ -1,5 +1,5 @@
 module Api::V1
-  class NoJobProvidedError < StandardError
+  class NoJobProvidedError < GranblueError
     def http_status
       422
     end

app/errors/api/v1/NoJobSkillProvidedError.rb

@@ -1,5 +1,5 @@
 module Api::V1
-  class NoJobSkillProvidedError < StandardError
+  class NoJobSkillProvidedError < GranblueError
     def http_status
       422
     end

app/errors/api/v1/SameFavoriteUserError.rb

@@ -1,22 +1,20 @@
-module Api::V1
+module Api
-    class SameFavoriteUserError < StandardError
+  module V1
-        def http_status
+    class SameFavoriteUserError < GranblueError
-            422
+      def code
-        end
+        'same_favorite_user'
+      end
 
-        def code
+      def message
-            "same_favorite_user"
+        'Users cannot favorite their own parties'
-        end
+      end
 
-        def message
+      def to_hash
-            "Users cannot favorite their own parties"
+        {
-        end
+          message: message,
-
+          code: code
-        def to_hash
+        }
-            {
+      end
-                message: message,
-                code: code
-            }
-        end
     end
+  end
 end

app/errors/api/v1/TooManySkillsOfTypeError.rb

@@ -2,15 +2,7 @@
 
 module Api
   module V1
-    class TooManySkillsOfTypeError < StandardError
+    class TooManySkillsOfTypeError < GranblueError
-      def initialize(data)
-        @data = data
-      end
-
-      def http_status
-        422
-      end
-
       def code
         'too_many_skills_of_type'
       end