granblue.team/hensei-api
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor skills_are_unique

Browse source
This commit is contained in:
Justin Edmund 2022-12-30 16:53:22 -08:00
parent 9387bd321f
commit eaa6234714
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/models/party.rb
View file

@ -61,13 +61,13 @@ class Party < ApplicationRecord
def skills_are_unique def skills_are_unique
skills = [skill0, skill1, skill2, skill3].compact skills = [skill0, skill1, skill2, skill3].compact
return unless skills.uniq.length != skills.length return if skills.uniq.length == skills.length
errors.add(:skill1, 'must be unique') if skill0 == skill1 skills.each_with_index do |skill, index|
next if index.zero?
errors.add(:skill2, 'must be unique') if skill0 == skill2 || skill1 == skill2 errors.add(:"skill#{index + 1}", 'must be unique') if skills[0...index].include?(skill)
end
errors.add(:skill3, 'must be unique') if skill0 == skill3 || skill1 == skill3 || skill2 == skill3
errors.add(:job_skills, 'must be unique') errors.add(:job_skills, 'must be unique')
end end