A tool to help Granblue Fantasy players create and share teams and strategies.
9504dd7003
## Summary This PR fixes several pre-existing type errors identified by `svelte-check`: 1. **PartyService constructor** - Removed unused `fetch` argument from constructor call in `teams/[id]/+page.server.ts`. The `PartyService` class has an empty constructor that doesn't accept any parameters. 2. **PaginatedResponse property** - Changed `response.per` to `response.perPage` in `teams/explore/+page.server.ts` to match the `PaginatedResponse<T>` type definition. 3. **Broken test files** - Removed 3 test files that were importing non-existent `actions` exports: - `database/characters/[id]/page.server.test.ts` - `database/summons/[id]/page.server.test.ts` - `database/weapons/[id]/page.server.test.ts` These tests were testing SvelteKit form actions that don't exist in the corresponding `+page.server.ts` files. Reduces `svelte-check` errors from 419 to 366 (-53 errors). ## Review & Testing Checklist for Human - [ ] **Verify party loading works** - Navigate to `/teams/[shortcode]` and confirm party data loads correctly. The `PartyService` now uses `partyAdapter` directly without a custom fetch function - verify this works on both client and server. - [ ] **Verify explore pagination** - Navigate to `/teams/explore` and confirm pagination displays correctly (page count, items per page). - [ ] **Confirm deleted tests were not needed** - The removed tests were for form actions (`actions.save`) that don't exist. Verify there's no plan to implement these actions soon, or if there is, the tests should be re-added when the actions are implemented. ### Notes The deleted test files were testing functionality that doesn't exist - they imported `actions` from page.server.ts files that only export `load` functions, not form actions. If database entity editing via form actions is planned, new tests should be written when that functionality is implemented. Link to Devin run: https://app.devin.ai/sessions/611580bc2db94e20a48c3692d3cbd432 Requested by: Justin Edmund (justin@jedmund.com) / @jedmund Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Justin Edmund <justin@jedmund.com> |
||
|---|---|---|
| .storybook | ||
| .vscode | ||
| messages | ||
| project.inlang | ||
| src | ||
| static | ||
| .gitignore | ||
| .mcp.json | ||
| .npmrc | ||
| .prettierignore | ||
| .prettierrc | ||
| CLAUDE.md | ||
| eslint.config.js | ||
| package.json | ||
| pnpm-lock.yaml | ||
| README.md | ||
| svelte.config.js | ||
| tsconfig.json | ||
| vite.config.ts | ||
| vitest-setup-client.ts | ||
| vitest.config.adapter.ts | ||
sv
Everything you need to build a Svelte project, powered by sv.
Creating a project
If you're seeing this, you've probably already done this step. Congrats!
# create a new project in the current directory
npx sv create
# create a new project in my-app
npx sv create my-app
Developing
Once you've created a project and installed dependencies with npm install (or pnpm install or yarn), start a development server:
npm run dev
# or start the server and open the app in a new browser tab
npm run dev -- --open
Building
To create a production version of your app:
npm run build
You can preview the production build with npm run preview.
To deploy your app, you may need to install an adapter for your target environment.