Commit graph

108 commits

Author SHA1 Message Date
Devin AI
cab0a84588 fix: type errors in svelte-main branch (372 -> 217 errors)
- Fix Button variant errors (outlined -> ghost, contained -> primary)
- Fix search.queries.ts import path and property names (snake_case -> camelCase)
- Fix PartyContext export from party.service.ts
- Fix User type missing avatar property
- Fix exactOptionalPropertyTypes violations in Unit components
- Fix MenuItems Props interface
- Fix RequestOptions, SearchParams, SearchFilters types
- Fix UpdateUncapParams type
- Fix Select.ItemIndicator and maxLength errors
- Fix Summon/Weapon hp/atk properties in entity.adapter.ts

Co-Authored-By: Justin Edmund <justin@jedmund.com>
2025-11-28 20:32:38 +00:00
Devin AI
dfbb1e4e48 fix: type errors and cleanup for svelte-main branch
- Fix RequestOptions cache type incompatibility in adapters/types.ts
- Add missing properties to Character type in entity.adapter.ts and entities.ts
- Create adapters index.ts for module exports
- Update users.ts to use userAdapter instead of removed core module
- Fix UserSettingsModal.svelte switch import and type errors
- Add type shims for wx-svelte-grid and $env/static/public
- Accept upstream versions for SearchSidebar.svelte and teams/new/+page.svelte
- Add CLEANUP_PLAN.md documenting remaining work

Reduces type errors from ~412 to ~378. See CLEANUP_PLAN.md for remaining fixes.

Co-Authored-By: Justin Edmund <justin@jedmund.com>
2025-11-28 20:08:10 +00:00
a208a3c1ea fix: merge conflict 2025-11-28 11:50:07 -08:00
devin-ai-integration[bot]
7a0e3b4f3d
Low-risk cleanup: unused imports, gitignore, auth types, test routes (#439)
## Summary

This PR performs low-risk cleanup tasks on the svelte-main branch:

1. **Remove unused imports** from `base.adapter.ts` - `snakeToCamel` and
`camelToSnake` were imported but never used
2. **Add `/.next` to `.gitignore`** - This is a SvelteKit project but
had a stale Next.js build artifact showing in git status
3. **Fix broken auth import** - `map.ts` was importing
`UserInfoResponse` from `$lib/api/resources/users` which never existed.
Created the type in `oauth.ts` based on actual usage in `buildCookies()`
4. **Remove test/example routes** - Deleted development scaffolding that
had no references elsewhere:
   - `src/lib/components/examples/SearchExample.svelte`
   - `src/routes/test-sidebar/+page.svelte`
   - `src/routes/test/drag-drop/+page.svelte`

## Review & Testing Checklist for Human

- [ ] **Verify `UserInfoResponse` type matches actual API response** - I
inferred the type from usage in `map.ts`, but haven't verified against
the actual `/users/info` endpoint response from hensei-api. Fields:
`id`, `username`, `role`, `avatar.picture`, `avatar.element`,
`language`, `gender`, `theme`
- [ ] **Confirm test routes are not needed** - These appeared to be dev
scaffolding with no code references, but verify they're not used in any
manual QA workflows
- [ ] **Test auth flow** - Login/signup should still work correctly with
the new type location

**Recommended test plan:** Log in to the app and verify user info
(avatar, language, theme preferences) loads correctly after
authentication.

### Notes

- The broken `$lib/api/resources/users` import was pre-existing (the
file never existed), not caused by the previous API layer cleanup PR
- Running `pnpm check` confirms the auth/map error is resolved;
remaining type errors are unrelated pre-existing issues

Link to Devin run:
https://app.devin.ai/sessions/611580bc2db94e20a48c3692d3cbd432
Requested by: Justin Edmund (justin@jedmund.com) / @jedmund

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Justin Edmund <justin@jedmund.com>
2025-11-28 11:21:24 -08:00
5dc0a75cce misc fixes for grid service and resources
- let backend compute default uncap levels
- fix InfiniteScroll resource lifecycle (don't destroy on unmount)
- improve party resource error handling with type narrowing
- use SvelteMap/SvelteDate for reactivity
2025-11-28 11:04:36 -08:00
b1bfe82507 fix party job/skill API calls
- use shortcode instead of id for job updates
- wrap job_id in party object for rails API
- only send editable skill slots (1-3), skip null values
- add updateAccessory method stub
2025-11-28 11:04:26 -08:00
5403aebe48 fix job skill types and slot styling
- update JobSkill type with emp/base boolean flags
- use new skill fields in jobUtils and components
- update job adapter with locale and filter params
- restyle empty skill slots with cleaner placeholder
- simplify ML badge to not show level number
2025-11-28 11:04:16 -08:00
0379cff81e add active unit highlighting with element focus rings
- track active item in sidebar store
- add element accent colors and focus ring mixins
- units show pulsing focus ring when selected in sidebar
- refactor units to use shared menu components
- update context menu test page
2025-11-28 11:04:04 -08:00
9a4a863ccd add shared unit menu components
- UnitMenuContainer for context/dropdown menu wrapper
- MenuItems for reusable action items
- GearMenuButton for hover-triggered dropdown
- shared scss styles for both menu variants
2025-11-28 11:03:52 -08:00
e582629552 refactor SearchSidebar with tanstack query
- replace manual fetch with createInfiniteQuery
- debounced search input with reactive filters
- pagination handled automatically via infinite scroll
- cleaner state management via query result
2025-11-28 11:03:42 -08:00
aa16d58175 add tanstack query with infinite scroll support
- integrate @tanstack/svelte-query into layout
- add query client factory and query keys
- new InfiniteScrollQuery component for paginated data
- search query options for weapons/characters/summons
- update dev port to 5174
2025-11-28 11:00:57 -08:00
50f7643763 update extra summons grid 2025-09-30 03:44:38 -07:00
a88411eb46 add context menu to job components 2025-09-30 03:43:41 -07:00
0ab2782697 wire up context menus to unit components 2025-09-30 03:42:57 -07:00
030c5916c7 add context menu ui components and i18n 2025-09-30 03:42:14 -07:00
f325836bf6 wrap extra sections in container component 2025-09-30 01:12:40 -07:00
45fc9237ad add purple theme styling for extra weapons 2025-09-30 01:11:44 -07:00
47b3a11fef update extra weapons grid with header and container 2025-09-30 01:11:39 -07:00
267658bb28 add extra weapon container components 2025-09-30 01:11:33 -07:00
d8e18c00e1 update ui components 2025-09-29 23:48:02 -07:00
6b40a3dec6 update grid and unit components 2025-09-29 23:47:45 -07:00
1298ae1a35 add mastery display 2025-09-29 23:46:04 -07:00
4161a615ba add job system 2025-09-29 23:45:50 -07:00
9537c57485 refactor details sidebar 2025-09-29 23:45:28 -07:00
1b2bee497b refactor segmented control 2025-09-29 23:44:37 -07:00
79c0de3128 remove barrel files and update imports 2025-09-29 23:37:37 -07:00
3666b8db86 add perpetuity ring toggle and fix grid api response handling 2025-09-25 01:08:25 -07:00
d13412dfb9 fix transcendence star positioning and update uncap styles 2025-09-25 00:26:29 -07:00
6762c2dab4 use new modifier utils in unit components 2025-09-25 00:26:17 -07:00
739c415284 add canonical/user version toggle to details sidebar 2025-09-25 00:25:07 -07:00
249877efe6 add sidebar modification display components 2025-09-25 00:24:36 -07:00
3bbebeb588 fix: prevent grid rep titles from stretching container 2025-09-24 22:52:50 -07:00
999f03f42c add infinite scrolling to explore and profile pages 2025-09-24 22:24:53 -07:00
9bb9bd6320 add user settings modal and page 2025-09-24 22:02:25 -07:00
5678e13afb Don’t show selection on all /teams routes 2025-09-24 14:40:30 -07:00
6034157d07 add element-based backgrounds to detail sidebar 2025-09-24 03:49:20 -07:00
506d33bf57 fix character rep image urls 2025-09-24 03:35:07 -07:00
89daa8e565 update character unit to use new image function 2025-09-24 03:29:53 -07:00
f8e9c411f7 use detail/base images in sidebar 2025-09-24 03:28:49 -07:00
bc2e7d6bdb fix dropdown double button issue 2025-09-24 02:52:24 -07:00
e2c71ad28d add element theming and avatar to navigation 2025-09-24 02:52:01 -07:00
7889b7c59b fix button component renderAs logic 2025-09-24 02:51:23 -07:00
94ad52252e Update to use Button component
Also removes redundant styles
2025-09-24 01:53:59 -07:00
8db94e37e7 Update Button component to have shape and element 2025-09-24 01:53:26 -07:00
6ace86a00e Fix various spacing and sizing issues on party details 2025-09-24 01:24:57 -07:00
d8eb6b965a Update description sidebar padding and title 2025-09-24 00:45:40 -07:00
b564a5e5e0 Update layout
Sidebar now animates properly. Navigation has progressive blur behind it on scroll
2025-09-24 00:45:28 -07:00
06a91bd532 Add Youtube video rendering to DescriptionRenderer 2025-09-24 00:43:06 -07:00
0c03332988 update ui components for better interaction 2025-09-23 22:09:39 -07:00
838e09d17b add sidebar components for descriptions and details 2025-09-23 22:08:51 -07:00