Commit graph

273 commits

Author SHA1 Message Date
27441146ed
Re-implement latest PRs on a clean Git history (#86)
* Add granblue_id to WeaponKeys (#77)

Reimplementing #77

* Adds Ultimate Mastery and renames Master Level (#78)

* Render :created view on remix (#84)

This view is required as it shows the `edit_key` for unauth users
2023-03-17 05:03:50 -07:00
472fb6816b Allow adding EMP skills from prior rows to team
We let you search but didn't fix the server-side validation check for skills
2023-02-05 16:41:54 -08:00
158786b5a8 Show EMP skills for Row 5 classes
Row 4 EMP skills were not showing up, so you couldn't set Rage IV on Viking, for example
2023-02-05 16:32:57 -08:00
e2c1639d8f Remove log call 2023-02-05 15:49:09 -08:00
06f8d28874
February 2023 Update (#48) 2023-02-04 23:46:12 -08:00
78df1df683 Allow empty strong params 2023-01-08 01:30:12 -08:00
382b2e2a92 Enable extra if the GridWeapon is in position 9, 10, 11 2023-01-08 01:16:43 -08:00
beeeef3104 TEMP: Comment out problematic code
We don't ever send parameters when posting a party, so for now we don't need to worry about this.

We can't leave this like this though: You should be able to send a complete party in the future (for API creation via strings)
2023-01-08 01:16:25 -08:00
3226acdf4a Allow input of expanded details and output them 2023-01-03 08:05:47 -08:00
fb037b3249 Fix testing conflict_characters 2023-01-03 02:41:38 -08:00
5e4cb4fe2b Fix reference to weapon series 2023-01-03 02:41:30 -08:00
a5237d2fa0 Add AX type to blueprint 2023-01-02 21:32:11 -08:00
83c6b2397a Refactor weapon conflicts into model validations 2023-01-02 21:24:53 -08:00
c39abfe8d6 Fix AX reference
Was using int, now uses bool
2023-01-02 21:24:43 -08:00
1789dcee4b Move conflict detection code to GridWeapon 2023-01-02 16:25:35 -08:00
eaa6234714 Refactor skills_are_unique 2023-01-02 16:25:35 -08:00
9387bd321f Refactor GridCharactersController
This is a similar refactor to GridWeaponsController
2023-01-02 16:25:35 -08:00
ebbbdc174b Fix bug in GridCharactersController refactor
This would show a conflict modal for any weapon as long as one of the weapons was an opus or draconic
2023-01-02 16:25:35 -08:00
839be176ad Revert gridweaponscontroller refactor 2022-12-30 15:39:47 -08:00
7049e8e723 Fix bug introduced in last PR 2022-12-30 06:09:58 -08:00
3e77365635 Refactor #create
This method is humongous and very confusing, and often gives double render errors. This refactor breaks things up into smaller methods to help make it a bit more readable.
2022-12-30 05:08:40 -08:00
6f588386d0 Filter out grids that don't have more than two distinct weapons 2022-12-29 02:36:52 -08:00
1752081f3f Output theme 2022-12-25 20:17:20 -08:00
383d59703f Add theme to user table and blueprint 2022-12-25 16:01:40 -08:00
e2332f9652 Allow searching only for extra or subaura objects 2022-12-25 00:29:55 -08:00
adbb5b6c7d Disallow adding arbitrary weapons to Extra slots 2022-12-25 00:23:27 -08:00
ec25230bc5 Implement detecting and resolving weapon conflicts 2022-12-24 23:30:10 -08:00
7a8cf30ffb Fix series for Class Champion emblems 2022-12-24 04:55:11 -08:00
ae1da20f27 Fix fetching weapon keys so you dont need filters 2022-12-24 04:54:50 -08:00
4f4d9e27a7 Add slug to weapon key table 2022-12-23 23:31:34 -08:00
ddae480f48 Merge branch 'main' into awakening 2022-12-23 19:28:03 -08:00
f17be0ea03 Merge branch 'main' of github.com:jedmund/hensei-api 2022-12-23 19:24:12 -08:00
e0df40f035 Remove log 2022-12-23 19:22:45 -08:00
574d8e0b3e Normalize constants in ApiController 2022-12-23 19:08:36 -08:00
6ccc8fd338 Add awakenings to blueprints 2022-12-23 16:40:42 -08:00
13dae81737 Fix bug preventing selecting Row IV, V and EXII 2022-12-23 15:49:30 -08:00
8b69a44d83 Allow unsetting of jobs
Unsetting a job also removes all of its skills
2022-12-23 15:42:46 -08:00
464fe2f1aa Update output for GridObjects when uncapping 2022-12-22 23:41:04 -08:00
a837210029 Removed current job's subskills from search 2022-12-22 23:27:46 -08:00
874c20245d Refined selecting skills based on job
* Bugfix: You can now select a third subskill on Rows 1, 2 and 3
* Edgecase: When switching from a Row 1, 2 or 3 class to Row 4, 5 or EX2, the third EMP skill set is removed
2022-12-22 23:27:24 -08:00
8c1d51fb4f Updated getting skills assignable to a job
This endpoint isn't used though
2022-12-22 23:26:23 -08:00
b7a537f540 Fix token generation on signup 2022-12-22 21:27:38 -08:00
041f8ee189 Fix errors with error handling 2022-12-22 18:12:47 -08:00
e91e1664a6 Update blueprint for availability endpoints 2022-12-22 18:12:34 -08:00
153d36be5a We need to include the User in the Party 2022-12-22 01:40:02 -08:00
a397fc722d Pass root when rendering in SearchController 2022-12-22 01:01:03 -08:00
c5391a6683 Fix bug where now wasn't replaced 2022-12-22 00:44:39 -08:00
7ddc916216 Remove rabl views
Our work here is done
2022-12-21 23:29:20 -08:00
c0be03dcb6 Finish migrating ApiController error methods 2022-12-21 23:28:54 -08:00
415ef39158 Add per_page to methods that return collections 2022-12-21 23:15:17 -08:00
5c97488a20 Update UsersController to use blueprinter 2022-12-21 23:13:19 -08:00
41c031092e Update weapon_keys_controller.rb 2022-12-21 22:10:35 -08:00
89e666219a Update SearchController for blueprinter 2022-12-21 22:10:31 -08:00
9a27ac853d Update JobsController and JobSkillsController for blueprinter 2022-12-21 21:46:35 -08:00
349c42f839 Update blueprints to remove id field or identifier
This is built into ApiBlueprint
2022-12-21 21:07:26 -08:00
3b6edfae5d Update WeaponKey output for blueprinter 2022-12-21 21:04:42 -08:00
116ec9dbbc Refactor GridObjectControllers to use blueprinter 2022-12-21 20:53:48 -08:00
2a74b8aa4d Add minimal view to Party and use in GridObject 2022-12-21 20:53:34 -08:00
a15ba3c376 Correct ConflictBlueprint
ConflictBlueprint uses `options` to display arbitrary values, but I think those are only available behind conditional statements. This adds those statements and checks if the key that will be used exists on the hash.

ConflictBlueprint was also inheriting from ApiBlueprint which requires a real object (with an ID), so instead we inherit from Blueprinter::Base
2022-12-21 20:40:27 -08:00
747ffbc4ff Update GridObject blueprints with view 2022-12-21 20:39:17 -08:00
33775539cd Add ConflictBlueprint
This should be used for character conflicts (implemented) and weapon conflicts (to-do in a future PR)
2022-12-21 19:27:55 -08:00
bf04ddcbba Fix GridObject blueprints 2022-12-21 19:27:33 -08:00
979d28be75 Update party_blueprint.rb 2022-12-21 16:20:04 -08:00
af51869927 Fix build_conditions method
The method of assigning values was assigning nil if the value wasn't present in `params`, which is bad
2022-12-21 16:20:00 -08:00
5b37e480f8 Refactor FavoritesController for blueprinter 2022-12-21 16:10:53 -08:00
f86aa30791 GranblueError should not require input param 2022-12-21 15:50:06 -08:00
44e92733d3 Refactor RaidsController for blueprinter 2022-12-21 15:35:05 -08:00
290099e2f4 Refactor PartiesController for blueprinter
* Refactored and tried to simplify methods in PartiesController
* Implemented new error render methods in ApiController
* Removed parties/[weapons, summons, characters] routes
2022-12-21 15:34:54 -08:00
e541182e36 Add all blueprints and associate with models 2022-12-21 03:31:55 -08:00
a1ff18092d Create error_blueprint.rb 2022-12-21 01:20:55 -08:00
31e62e073c Create api_blueprint.rb 2022-12-21 01:20:13 -08:00
712c866296 Remove rabl 2022-12-21 01:16:34 -08:00
c1716c1e4f Run RuboCop on everything
yolo
2022-12-21 00:22:47 -08:00
9e2f9c0af1 Fix job creation 2022-12-03 20:13:48 -08:00
a8301019f5 Fix search for base skills
Before they didn't really show up at all, then they showed up on everything, then they showed up on EX1 and EX2, now they only show up on EX2.
2022-12-03 18:34:38 -08:00
fc7cde4c5a Fix race condition for base skill mismatch check 2022-12-03 18:21:15 -08:00
a08421722f Add GranblueError and move app errors to extend it 2022-12-03 18:21:01 -08:00
6ba5335668 Fix last bugs around adding skills with 0~3 existing 2022-12-03 16:39:38 -08:00
813c2ba202 Fix bug regarding finding old_position 2022-12-03 14:51:01 -08:00
243ba2de3e Fix bug when desired position is empty 2022-12-03 14:10:18 -08:00
27d31d61c0 Fix race condition 2022-12-03 13:55:41 -08:00
ec3b42101b Move logic to JobsController
It was getting too heavy to keep in PartiesController
2022-12-03 11:45:00 -08:00
bd33ee44fc Update Job model to reference base_job 2022-12-03 11:44:09 -08:00
4ee90f6c09 Add new errors and fix handling in ApiController 2022-12-03 11:43:56 -08:00
5c9a2b8d7a Refactor job skill assignment a bit 2022-12-02 20:46:51 -08:00
f6613d6e91 Add TooManySkillsOfTypeError 2022-12-02 20:45:46 -08:00
644ffd74e5 Added logic for swapping and replacing job skills 2022-12-02 11:20:43 -08:00
d1eba7aed8 Add == and update search 2022-12-02 11:20:22 -08:00
aa5d2451a8 Add skill uniqueness validation to Party 2022-12-02 11:20:11 -08:00
741d20aa70 Send job and skills when party is updated 2022-12-01 04:47:31 -08:00
296fa0187c Save base job skills on job change 2022-12-01 04:46:53 -08:00
1ba16a2c61 Export job skills in template 2022-12-01 04:46:44 -08:00
ae36ff59b4 Properly gate group conditions
The default group ("All Skills") is technically -1, not null
2022-11-30 05:17:40 -08:00
a69fda5ead Small refactor of handling groups
Using the `filters` key so we can hook into existing search infrastructure on the frontend
2022-11-30 02:51:58 -08:00
c0bdb47d43 Add scoped search for job skills 2022-11-30 02:03:28 -08:00
353db31ef7 Move to JobSkillsController
It makes more sense to pre-fetch all job skills and filter on the client, so we're consolidating into a JobSkillsController
2022-11-27 19:27:45 -08:00
5755aab240 Disable object root 2022-11-27 18:54:32 -08:00
5fe712c31a Add route to get skills for given job 2022-11-27 14:12:52 -08:00
b9bea3ecf4 Add model 2022-11-27 14:12:33 -08:00
559507977b Added logic for conflict resolution
* Conflict is detected when attempting to save a new GridCharacter
* New `resolve` method executes the replacement
* Template to render a decision on the frontend
2022-11-19 06:03:39 -08:00